This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
hasStrings on Android #20393
Merged
Merged
hasStrings on Android #20393
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e4ddb31
Implement hasStrings in terms of getClipboardData on Android
justinmc f723cfc
WIP trying and failing to test this
justinmc 5d5c9b2
Test hasStrings message
justinmc fdf79d6
Test real hasStrings call but not working due to inability to mock Cl…
justinmc d2f40f4
Fix hasStrings test and ClipboardManager mocking
justinmc 585c7e2
Formatting
justinmc 3e1eb3d
Omit 'public' and split tests so they're in the correct packages
justinmc f606805
Formatting
justinmc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaaclarke You helped me test this same thing on iOS, do you know how I can do it on Android? I'm sure there's a way for me to just send the Clipboard.hasStrings message, but I'm struggling to figure it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make a test against PlatformChannel that has a mock
platformMessageHandlerand you can call intoonMethodCall. As for testing PlatformPlugin, can't you just callsetClipboardDataon it then callclipboardHasStringsto testclipboardHasStrings? Once you have those 2 tests written you'll have complete test coverage of your PR (in isolation as unit tests, not integration tests).