Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] increase number of shards. sync engine web tests same as flutter repo #20164

Merged
nturgut merged 3 commits into from
Aug 1, 2020
Merged

[web] increase number of shards. sync engine web tests same as flutter repo #20164

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe5826d
increase number of shards. make engine web tests same as flutter repo…
Jul 30, 2020
4124e8d
remove golden arguments. tests failed
Jul 30, 2020
1c10102
adding comments
Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ web_shard_template: &WEB_SHARD_TEMPLATE
only_if: "changesInclude('.cirrus.yml', 'DEPS', 'lib/web_ui/**', 'web_sdk/**') || $CIRRUS_PR == ''"
environment:
# As of March 2020, the Web shards needed 16G of RAM and 4 CPUs to run all framework tests with goldens without flaking.
WEB_SHARD_COUNT: 12
CPU: 4
MEMORY: 16G
WEB_SHARD_COUNT: 4
CHROME_NO_SANDBOX: true
GOLD_SERVICE_ACCOUNT: ENCRYPTED[3afeea5ac7201151c3d0dc9648862f0462b5e4f55dc600ca8b692319622f7c3eda3d577b1b16cc2ef0311b7314c1c095]
Copy link
Copy Markdown
Contributor Author

@nturgut nturgut Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Piinks Do you know what GOLD_SERVICE_ACCOUNT is used for, this was added to web shards for flutter/flutter but was missing on the engine side, so I'm also adding this value here.

Copy link
Copy Markdown
Contributor

@mdebbar mdebbar Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests are passing without it, it's probably not needed here.

Copy link
Copy Markdown
Contributor Author

@nturgut nturgut Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seems like they failed. so I'll try another run without it.

Copy link
Copy Markdown
Contributor

@godofredoc godofredoc Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we missing to migrate this tests to LUCI?

compile_host_script: |
cd $ENGINE_PATH/src
./flutter/tools/gn --unoptimized --full-dart-sdk
Expand Down Expand Up @@ -108,7 +110,31 @@ task:
- name: web_tests-2-linux
<< : *WEB_SHARD_TEMPLATE

- name: web_tests-3_last-linux # last Web shard must end with _last
- name: web_tests-3-linux
<< : *WEB_SHARD_TEMPLATE

- name: web_tests-4-linux
<< : *WEB_SHARD_TEMPLATE

- name: web_tests-5-linux
<< : *WEB_SHARD_TEMPLATE

- name: web_tests-6-linux
<< : *WEB_SHARD_TEMPLATE

- name: web_tests-7-linux
<< : *WEB_SHARD_TEMPLATE

- name: web_tests-8-linux
<< : *WEB_SHARD_TEMPLATE

- name: web_tests-9-linux
<< : *WEB_SHARD_TEMPLATE

- name: web_tests-10-linux
<< : *WEB_SHARD_TEMPLATE

- name: web_tests-11_last-linux # last Web shard must end with _last
<< : *WEB_SHARD_TEMPLATE

- name: build_test
Expand Down