Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix usage of WeakPtr valid check #20106

Merged
cbracken merged 1 commit into from
Sep 9, 2020
Merged

Fix usage of WeakPtr valid check #20106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shell/common/animator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ void Animator::BeginFrame(fml::TimePoint frame_start_time,
task_runners_.GetUITaskRunner()->PostDelayedTask(
[self = weak_factory_.GetWeakPtr(),
notify_idle_task_id = notify_idle_task_id_]() {
if (!self.get()) {
if (!self) {
return;
}
// If our (this task's) task id is the same as the current one
Expand Down Expand Up @@ -222,7 +222,7 @@ void Animator::RequestFrame(bool regenerate_layer_tree) {

task_runners_.GetUITaskRunner()->PostTask([self = weak_factory_.GetWeakPtr(),
frame_number = frame_number_]() {
if (!self.get()) {
if (!self) {
return;
}
TRACE_EVENT_ASYNC_BEGIN0("flutter", "Frame Request Pending", frame_number);
Expand Down
2 changes: 1 addition & 1 deletion shell/common/shell.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,7 +1188,7 @@ void Shell::OnFrameRasterized(const FrameTiming& timing) {
frame_timings_report_scheduled_ = true;
task_runners_.GetRasterTaskRunner()->PostDelayedTask(
[self = weak_factory_gpu_->GetWeakPtr()]() {
if (!self.get()) {
if (!self) {
return;
}
self->frame_timings_report_scheduled_ = false;
Expand Down