This repository was archived by the owner on Feb 25, 2025. It is now read-only.
ensure we do not double publish to CIPD #19724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually, I see I have to do the same for merge_and_upload_debug_symbols.py |
Contributor
Author
|
Updated to support both scripts (and actually invoke the command) @iskakaushik, PTAL. |
4 tasks
Contributor
Author
|
the two yellow tasks passed on LUCI, so I will merge. |
Contributor
|
The linux-fuchsia build seems to be broken after this PR landed https://ci.chromium.org/p/flutter/builders/prod/Linux%20Fuchsia/4525 |
Contributor
|
@a-siva i'll revert |
iskakaushik
pushed a commit
to iskakaushik/engine
that referenced
this pull request
Jul 15, 2020
This reverts commit 56bb3c5.
iskakaushik
added a commit
that referenced
this pull request
Jul 15, 2020
Contributor
|
revert landed at #19759 |
Contributor
|
Thanks |
Contributor
Author
Thanks @iskakaushik |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 15, 2020
christopherfujino
added a commit
that referenced
this pull request
Aug 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CIPD will allow multiple package instances to be created with the same tag, but then subsequent downloading will fail. This change checks if the tag already exists first before publishing. cc @renyou
Related Issues
Related to flutter/flutter#55082