Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Rebuild CkPath on top of @JS bindings with 3.28x speed-up on the path benchmark #19694

Merged
yjbanov merged 4 commits into from
Jul 14, 2020
Merged

Rebuild CkPath on top of @JS bindings with 3.28x speed-up on the path benchmark #19694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24600b5
SkPath bindings
yjbanov Jul 12, 2020
b5099da
CkPath uses SkPath
yjbanov Jul 12, 2020
c88b843
lazy initialize CkPath._legacyJsObject
yjbanov Jul 12, 2020
3ec3ebb
shader and image binding fixes
yjbanov Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/web_ui/lib/src/engine/compositor/canvas.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class CkCanvas {
final CkPath skPath = path as CkPath;
final js.JsObject? intersectClipOp = canvasKit['ClipOp']['Intersect'];
skCanvas.callMethod('clipPath', <dynamic>[
skPath._skPath,
skPath._legacyJsObject,
intersectClipOp,
doAntiAlias,
]);
Expand Down Expand Up @@ -78,7 +78,7 @@ class CkCanvas {
) {
final CkImage skAtlas = atlas as CkImage;
skCanvas.callMethod('drawAtlas', <dynamic>[
skAtlas.skImage,
skAtlas.legacyJsObject,
rects,
rstTransforms,
paint.skiaObject,
Expand Down Expand Up @@ -114,7 +114,7 @@ class CkCanvas {
void drawImage(ui.Image image, ui.Offset offset, CkPaint paint) {
final CkImage skImage = image as CkImage;
skCanvas.callMethod('drawImage', <dynamic>[
skImage.skImage,
skImage.legacyJsObject,
offset.dx,
offset.dy,
paint.skiaObject,
Expand All @@ -124,7 +124,7 @@ class CkCanvas {
void drawImageRect(ui.Image image, ui.Rect src, ui.Rect dst, CkPaint paint) {
final CkImage skImage = image as CkImage;
skCanvas.callMethod('drawImageRect', <dynamic>[
skImage.skImage,
skImage.legacyJsObject,
makeSkRect(src),
makeSkRect(dst),
paint.skiaObject,
Expand All @@ -136,7 +136,7 @@ class CkCanvas {
ui.Image image, ui.Rect center, ui.Rect dst, CkPaint paint) {
final CkImage skImage = image as CkImage;
skCanvas.callMethod('drawImageNine', <dynamic>[
skImage.skImage,
skImage.legacyJsObject,
makeSkRect(center),
makeSkRect(dst),
paint.skiaObject,
Expand Down Expand Up @@ -176,7 +176,7 @@ class CkCanvas {
void drawPath(ui.Path path, CkPaint paint) {
final js.JsObject? skPaint = paint.skiaObject;
final CkPath enginePath = path as CkPath;
final js.JsObject? skPath = enginePath._skPath;
final js.JsObject? skPath = enginePath._legacyJsObject;
skCanvas.callMethod('drawPath', <js.JsObject?>[skPath, skPaint]);
}

Expand Down
Loading