Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Only attempt surface creation in viewDidLayoutSubviews if the application is active. #19592

Merged
chinmaygarde merged 1 commit into from
Jul 8, 2020
Merged

Only attempt surface creation in viewDidLayoutSubviews if the application is active. #19592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,9 +848,15 @@ - (void)viewDidLayoutSubviews {
[self updateViewportPadding];
[self updateViewportMetrics];

// There is no guarantee that UIKit will layout subviews when the application is active. Creating
// the surface when inactive will cause GPU accesses from the background. Only wait for the first
// frame to render when the application is actually active.
bool applicationIsActive =
[UIApplication sharedApplication].applicationState == UIApplicationStateActive;

// This must run after updateViewportMetrics so that the surface creation tasks are queued after
// the viewport metrics update tasks.
if (firstViewBoundsUpdate) {
if (firstViewBoundsUpdate && applicationIsActive) {
[self surfaceUpdated:YES];

flutter::Shell& shell = [_engine.get() shell];
Expand Down