Add `GetBoundingRectAfterMutations` to EmbeddedViewParams to calculate the final bounding rect for platform view #19170

cyanglaz · 2020-06-19T20:51:45Z

Description

Adds a method to calculate the final bounding rect of the platform view.
Clippings are currently ignored

Related Issues

Tests

embedded_view_params_unittests.cc

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the contributor guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the C++, Objective-C, Java style guides for the engine.
I read the tree hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

blasten · 2020-06-19T20:57:13Z

flow/embedded_views.h

+  // https://github.com/flutter/flutter/issues/59821
+  SkRect GetBoundingRectAfterMutations() const {
+    SkPath path;
+    SkRect starting_rect = SkRect::MakeSize(sizePoints);


does it still need the offsetPixels?

I think mutator stack should contain all the offset informations already, By querying through the stack, we have the final offset

cyanglaz · 2020-06-20T00:16:46Z

@blasten updated with our offline discussion

blasten · 2020-06-20T18:18:08Z

flow/embedded_views.h

+  const SkPoint& offsetPixels() const { return offset_pixels_; };
+  const SkSize& sizePoints() const { return size_points_; };
+  const MutatorsStack& mutatorsStack() const { return mutators_stack_; };
+  const SkRect& finalBoundingRect() const { return final_bounding_rect_; }


nit: could we document these methods?

blasten · 2020-06-20T18:20:35Z

shell/platform/embedder/embedder_layers.cc

-                       params.offsetPixels.y(),                          //
-                       params.sizePoints.width() * device_pixel_ratio_,  //
-                       params.sizePoints.height() * device_pixel_ratio_  //
+      SkRect::MakeXYWH(params.offsetPixels().x(),                          //


is this just finalBoundingRect() now?

I think the size is not the same as the bounding rect. The size points are the original size before applying mutation.

@chinmaygarde I thought params.sizePoints did not consider scaling and rotation at all? Does embedder free from scaling and rotation layers?

I believe the embedder is supposed to apply the scaling and rotation themselves from the data present in the mutator stack to get the final width and height. I believe there is a test for this in the embedder unit-tests harness and this should be documented in the header.

I meant this rect returned from this method does not include rotation and scaling. Want to make sure if the original size used here is intended.

Yes. It is.

blasten

LGTM + confirmation from @chinmaygarde

…calculate the final bounding rect for platform view (#19170)" This reverts commit f5c315f.

…calculate the final bounding rect for platform view (#19170)" (#19204) This reverts commit f5c315f.

…rams to calculate the final bounding rect for platform view (flutter#19170)" (flutter#19204)" This reverts commit 9cecc5f.

…calculate the final bounding rect for platform view #19170" (#19212)

…calculate the final bounding rect for platform view (flutter/engine#19170)

…calculate the final bounding rect for platform view (flutter#19170)" (flutter#19204) This reverts commit f5c315f.

…calculate the final bounding rect for platform view flutter#19170" (flutter#19212)

Chris Yang added 2 commits June 19, 2020 13:49

GetBoundingRectAfterMutations

86ba0b1

link todo to issue

2752b19

googlebot added the cla: yes label Jun 19, 2020

cyanglaz requested a review from blasten June 19, 2020 20:51

fix typo

617ead7

blasten reviewed Jun 19, 2020

View reviewed changes

Chris Yang added 2 commits June 19, 2020 14:03

fix unittest typo

60d9b7b

cache make bounding rect

9eb1d3a

fix license golden

822d11c

blasten reviewed Jun 20, 2020

View reviewed changes

Chris Yang added 2 commits June 20, 2020 11:59

add docs

ff81b85

formatting

15056ff

blasten approved these changes Jun 21, 2020

View reviewed changes

chinmaygarde approved these changes Jun 21, 2020

View reviewed changes

cyanglaz merged commit f5c315f into flutter:master Jun 22, 2020

cyanglaz deleted the mutator_stack_get_rect branch June 22, 2020 04:01

brianosman added a commit that referenced this pull request Jun 22, 2020

Revert "Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

ca6272d

…calculate the final bounding rect for platform view (#19170)" This reverts commit f5c315f.

brianosman mentioned this pull request Jun 22, 2020

Revert "Add GetBoundingRectAfterMutations to EmbeddedViewParams to calculate the final bounding rect for platform view" #19204

Merged

brianosman added a commit that referenced this pull request Jun 22, 2020

Revert "Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

9cecc5f

…calculate the final bounding rect for platform view (#19170)" (#19204) This reverts commit f5c315f.

cyanglaz mentioned this pull request Jun 22, 2020

Reland "Add GetBoundingRectAfterMutations to EmbeddedViewParams to calculate the final bounding rect for platform view #19170" #19212

Merged

cyanglaz pushed a commit that referenced this pull request Jun 22, 2020

Reland "Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

5b1b59a

…calculate the final bounding rect for platform view #19170" (#19212)

engine-flutter-autoroll mentioned this pull request Jun 23, 2020

Roll Engine from 91a63d6a44c5 to 2cb544dba7a0 (34 revisions) flutter/flutter#60046

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

c8ef1a1

…calculate the final bounding rect for platform view (flutter/engine#19170)

engine-flutter-autoroll mentioned this pull request Jun 23, 2020

Roll Engine from 91a63d6a44c5 to a4197d6310dc (35 revisions) flutter/flutter#60051

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

9f0c493

…calculate the final bounding rect for platform view (flutter/engine#19170)

engine-flutter-autoroll mentioned this pull request Jun 23, 2020

Roll Engine from 91a63d6a44c5 to a8635a42d882 (38 revisions) flutter/flutter#60057

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

5e092d8

…calculate the final bounding rect for platform view (flutter/engine#19170)

engine-flutter-autoroll mentioned this pull request Jun 23, 2020

Roll Engine from 91a63d6a44c5 to f1095d6b02af (39 revisions) flutter/flutter#60071

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

ccd174a

…calculate the final bounding rect for platform view (flutter/engine#19170)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

b62066e

…calculate the final bounding rect for platform view (flutter/engine#19170)

This was referenced Jun 23, 2020

Roll Engine from 91a63d6a44c5 to 210d7b47dc89 (40 revisions) flutter/flutter#60073

Closed

Roll Engine from 91a63d6a44c5 to 9c7c6b1487f1 (42 revisions) flutter/flutter#60076

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

266b2ea

…calculate the final bounding rect for platform view (flutter/engine#19170)

engine-flutter-autoroll mentioned this pull request Jun 23, 2020

Roll Engine from 91a63d6a44c5 to 0c3c332530b1 (43 revisions) flutter/flutter#60085

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

04cf755

…calculate the final bounding rect for platform view (flutter/engine#19170)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

0b7d1bd

…calculate the final bounding rect for platform view (flutter/engine#19170)

This was referenced Jun 23, 2020

Roll Engine from 91a63d6a44c5 to 0b7eeebf5332 (44 revisions) flutter/flutter#60091

Closed

Roll Engine from 91a63d6a44c5 to dd539c9806f5 (45 revisions) flutter/flutter#60098

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

ebca0e4

…calculate the final bounding rect for platform view (flutter/engine#19170)

engine-flutter-autoroll mentioned this pull request Jun 23, 2020

Roll Engine from 91a63d6a44c5 to 4986f25c0805 (46 revisions) flutter/flutter#60103

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

693e483

…calculate the final bounding rect for platform view (flutter/engine#19170)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

01c40b4

…calculate the final bounding rect for platform view (flutter/engine#19170)

This was referenced Jun 23, 2020

Roll Engine from 91a63d6a44c5 to 99ef01e53bbd (47 revisions) flutter/flutter#60108

Closed

Roll Engine from 91a63d6a44c5 to 99ef01e53bbd (47 revisions) flutter/flutter#60110

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

dab7b58

…calculate the final bounding rect for platform view (flutter/engine#19170)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 23, 2020

f5c315f Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

1847aa0

…calculate the final bounding rect for platform view (flutter/engine#19170)

engine-flutter-autoroll mentioned this pull request Jun 23, 2020

Roll Engine from 91a63d6a44c5 to 57d13339997f (49 revisions) flutter/flutter#60114

Merged

zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Jun 24, 2020

Revert "Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

9325351

…calculate the final bounding rect for platform view (flutter#19170)" (flutter#19204) This reverts commit f5c315f.

zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Jun 24, 2020

Reland "Add GetBoundingRectAfterMutations to EmbeddedViewParams to …

120a32f

…calculate the final bounding rect for platform view flutter#19170" (flutter#19212)

Add GetBoundingRectAfterMutations to EmbeddedViewParams to calculate the final bounding rect for platform view #19170

Add GetBoundingRectAfterMutations to EmbeddedViewParams to calculate the final bounding rect for platform view #19170

Uh oh!

Conversation

cyanglaz commented Jun 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Checklist

Breaking Change

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cyanglaz commented Jun 20, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blasten left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add `GetBoundingRectAfterMutations` to EmbeddedViewParams to calculate the final bounding rect for platform view #19170

Add `GetBoundingRectAfterMutations` to EmbeddedViewParams to calculate the final bounding rect for platform view #19170

cyanglaz commented Jun 19, 2020 •

edited

Loading