This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[iOS] text input methods to only call updateEditState once #19161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Jun 19, 2020
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Looks good, modulo the naming problems.
| } | ||
|
|
||
| - (void)setSelectedTextRange:(UITextRange*)selectedTextRange updateEditingState:(BOOL)update { | ||
| - (void)_setSelectedTextRange:(UITextRange*)selectedTextRange { |
Member
There was a problem hiding this comment.
In objc we don't prefix method names with _
Contributor
Author
There was a problem hiding this comment.
Changed to setSelectedTextRangeLocal
|
|
||
| - (void)replaceRange:(UITextRange*)range withText:(NSString*)text { | ||
| NSRange replaceRange = ((FlutterTextRange*)range).range; | ||
| - (void)_replaceRange:(NSRange)range withText:(NSString*)text { |
Member
There was a problem hiding this comment.
Same here with _replaceRange:
justinmc
approved these changes
Jun 22, 2020
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM
Great overall improvement, I feel like this could have been causing other subtle problems as well.
| FlutterTextInputPlugin* textInputPlugin; | ||
| } | ||
|
|
||
| - (void)setUp { |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2020
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Jun 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure iOS text plugin only makes one
updateEditStatecall at the end of everyUITextInputmethod that changes the state of the text.setMarkedText: selectedRange:currently updates twice when it gets called, and the first call reports an inconsistent state, breaking the interaction with the iOS Kana IME.Related Issues
Fixes flutter/flutter#59734
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.