-
Notifications
You must be signed in to change notification settings - Fork 6k
Roll buildroot to switch to VS 2019 #18045
Conversation
|
Notes to myself:
|
|
This pull request is not suitable for automatic merging in its current state.
|
|
Windows host unit tests keep timing out. Trying a resync to see if it was an unrelated issue, but it's possible that VS 2019 is breaking unit tests somehow. |
|
It's definitely breaking tests, so the buildroot change is being rolled back again. Based on recent experience with this bot, this may not actually be a timeout; C++ exceptions in unit tests on that bot cause this behavior too, without logging the exception, so that may well be what's happening. The fact that's unopt-only is consistent with that theory. Unfortunately I'm not able to repro locally so far, even though it's consistent on CI. |
|
Can we close this PR for now and attempt this at a later time if you don't have the cycles to work on it ATM? |
|
I'm still working on in intermittently. I'll convert to draft though since it's clearly not ready as-is. |
|
/cc @cbracken |
|
@stuartmorgan I'm assuming your work on this stalled, so I'm going to close the PR, but please don't hesitate to open a new one when you're ready. Thanks! |
Picks up flutter/buildroot#392
Fixes flutter/flutter#48831