Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Apr 30, 2020

@stuartmorgan-g stuartmorgan-g added the Work in progress (WIP) Not ready (yet) for review! label Apr 30, 2020
@auto-assign auto-assign bot requested a review from jason-simmons April 30, 2020 00:26
@stuartmorgan-g stuartmorgan-g removed the request for review from jason-simmons April 30, 2020 00:26
@stuartmorgan-g
Copy link
Contributor Author

Notes to myself:

  • Windows Android AOT needs goma disabled, as expected (until/unless we can move that to clang at some point too). Since it's not building much, my expectation is that the resulting slowdown won't be a significant problem.
  • Windows Host - static_assert failed due to requirement 'std::is_trivially_constructible<std::atomic<std::mutex *>>::value' -- Check to see if this is still an issue with latest Angle; the type of the mutex changed in Februrary.
  • Windows Web - same assert failure

@stuartmorgan-g stuartmorgan-g marked this pull request as draft June 10, 2020 19:15
@stuartmorgan-g stuartmorgan-g changed the title WIP: Test buildroot fork with VS 2019 Roll buildroot to switch to VS 2019 Aug 11, 2020
@stuartmorgan-g stuartmorgan-g marked this pull request as ready for review August 12, 2020 20:33
@stuartmorgan-g stuartmorgan-g added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. and removed Work in progress (WIP) Not ready (yet) for review! labels Aug 12, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 12, 2020
@stuartmorgan-g
Copy link
Contributor Author

Windows host unit tests keep timing out. Trying a resync to see if it was an unrelated issue, but it's possible that VS 2019 is breaking unit tests somehow.

@stuartmorgan-g
Copy link
Contributor Author

It's definitely breaking tests, so the buildroot change is being rolled back again. Based on recent experience with this bot, this may not actually be a timeout; C++ exceptions in unit tests on that bot cause this behavior too, without logging the exception, so that may well be what's happening. The fact that's unopt-only is consistent with that theory.

Unfortunately I'm not able to repro locally so far, even though it's consistent on CI.

@chinmaygarde
Copy link
Member

Can we close this PR for now and attempt this at a later time if you don't have the cycles to work on it ATM?

@chinmaygarde chinmaygarde added the Work in progress (WIP) Not ready (yet) for review! label Sep 3, 2020
@stuartmorgan-g
Copy link
Contributor Author

I'm still working on in intermittently. I'll convert to draft though since it's clearly not ready as-is.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft September 4, 2020 22:21
@stuartmorgan-g
Copy link
Contributor Author

/cc @cbracken

@Hixie
Copy link
Contributor

Hixie commented Oct 12, 2021

@stuartmorgan I'm assuming your work on this stalled, so I'm going to close the PR, but please don't hesitate to open a new one when you're ready. Thanks!

@Hixie Hixie closed this Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes Work in progress (WIP) Not ready (yet) for review!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update internal engine toolchain to VS 2019

5 participants