This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Batch systemFontChange messages#17885
Merged
ferhatb merged 3 commits intoflutter:masterfrom Apr 24, 2020
Merged
Conversation
yjbanov
reviewed
Apr 22, 2020
Contributor
yjbanov
left a comment
yjbanov
left a comment
There was a problem hiding this comment.
This change needs a test.
| if (!_fontChangeScheduled) { | ||
| _fontChangeScheduled = true; | ||
| // Batch updates into next animationframe. | ||
| html.window.requestAnimationFrame((num _) { |
Contributor
There was a problem hiding this comment.
This will debounce the notification at 16ms granularity, which seems too low for something that's loading over the network. Maybe use a Timer that debounces on the order of 100s of ms? We also have the AlarmClock with "snooze" feature for this sort of thing.
Contributor
Author
There was a problem hiding this comment.
Gallery loads 6 fonts, they are coming in within 1ms of each other. 1 font sometimes misses 16ms window and markrelayout is called second time. 100ms would delay app first build for many frames, there is no easy signal to cancel the wait and complete future.
yjbanov
approved these changes
Apr 24, 2020
| if (!_fontChangeScheduled) { | ||
| _fontChangeScheduled = true; | ||
| // Batch updates into next animationframe. | ||
| html.window.requestAnimationFrame((num _) { |
This was referenced Apr 24, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 25, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 25, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 25, 2020
This was referenced Apr 26, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 26, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2020
gaaclarke
added a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2020
flutter/engine@2b94311...4f888d6 git log 2b94311..4f888d6 --first-parent --oneline 2020-04-25 nurhan@google.com Change the repo fetch script used in integration tests (flutter/engine#17943) 2020-04-24 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1e21d14f2b8b..c12aad9485a9 (20 commits) (flutter/engine#17942) 2020-04-24 skia-flutter-autoroll@skia.org Roll src/third_party/dart a69cb6d700f5..216e3df4526c (16 commits) (flutter/engine#17945) 2020-04-24 xster@google.com Fix accessibility focus loss when first focusing on text field (flutter/engine#17803) 2020-04-24 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from _dAFU... to G4HpJ... (flutter/engine#17938) 2020-04-24 mouad.debbar@gmail.com [web] Fix exception when getting boxes for rich text range (flutter/engine#17933) 2020-04-24 ferhat@gmail.com [web] Batch systemFontChange messages (flutter/engine#17885) 2020-04-24 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from kpECk... to _dAFU... (flutter/engine#17929) 2020-04-24 skia-flutter-autoroll@skia.org Roll src/third_party/skia b965ff597315..1e21d14f2b8b (25 commits) (flutter/engine#17928) 2020-04-24 skia-flutter-autoroll@skia.org Roll src/third_party/dart 94178e920ee8..a69cb6d700f5 (22 commits) (flutter/engine#17926)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2020
This was referenced Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
This was referenced Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#55399