This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use the right constant for macOS event timestamps#17713
Merged
stuartmorgan-g merged 1 commit intoflutter:masterfrom Apr 15, 2020
Merged
Use the right constant for macOS event timestamps#17713stuartmorgan-g merged 1 commit intoflutter:masterfrom
stuartmorgan-g merged 1 commit intoflutter:masterfrom
Conversation
The NSEvent->Flutter event conversion code for pointer events was multiplying seconds by nanoseconds per milliseconds. While this does end up giving the right number of microseconds, it's a very confusing way to write it.
chinmaygarde
approved these changes
Apr 14, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
The NSEvent->Flutter event conversion code for pointer events was multiplying seconds by nanoseconds per milliseconds. While this does end up giving the right number of microseconds, it's a very confusing way to write it.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NSEvent->Flutter event conversion code for pointer events was
multiplying seconds by nanoseconds per milliseconds. While this does end
up giving the right number of microseconds, it's a very confusing way to
write it.