This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Run integration tests on ci#17598
Merged
nturgut merged 15 commits intoflutter:masterfrom Apr 13, 2020
Merged
Conversation
nturgut
force-pushed
the
run_int_tests_on_ci
branch
from
78ead30 to
4e156be
Compare
added 5 commits
April 9, 2020 10:26
nturgut
force-pushed
the
run_int_tests_on_ci
branch
from
6d6320b to
c3ff9e2
Compare
yjbanov
reviewed
Apr 9, 2020
Contributor
yjbanov
left a comment
yjbanov
left a comment
There was a problem hiding this comment.
Mostly nits. My only major concern is that we can end up with two versions of the engine and two versions of the framework as part of any given build. Which exact version is used depends on the environment we are running in. I'm worried that this will lead to unpredictable and non-reproducible build breakages.
added 9 commits
April 9, 2020 12:23
…cript for local usage
…po. always clone the repo even for local development, unless this flag is set
yjbanov
approved these changes
Apr 10, 2020
| /// commit. | ||
| /// | ||
| /// Use engine/src/flutter/.dart_tools to clone the Flutter repo. | ||
| /// TODO(nurhan): Use git pull instead if repo exists. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 13, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
* changing felt script to fetch flutter * changing the clone_flutter.sh code * running integration tests with felt on cirrus. fetch framework in CI (not in local). * only run cirrus tests on chrome. fix a comma in the flutter command path * adding comments to public flags * use local engine parameter for flutter pub get * change flutter executable used for flutter drive command * fix a cleanup issue. address comments. add toolException. enable web in flutter * address reviwer comments. fix issue with local-engine * address reviwer comments. fix issue with local-engine * using engine/flutter/.dart_tools as clone directory. enabling clone script for local usage * clean flutter repo with felt clean. add a flag to skip cloning the repo. always clone the repo even for local development, unless this flag is set * fixing typos. updating readme for the new flag. * fix directory error * addressing reviewer comments
blasten
reviewed
Apr 27, 2020
| io.Directory get engineDartToolDir => io.Directory(pathlib.join( | ||
| engineSrcDir.path, | ||
| 'flutter', | ||
| '.dart_tool', |
There was a problem hiding this comment.
This seems useful for android and iOS e2e too. We currently have duplicated scripts to build AOT/JIT apps, but it would be a win if we can just reuse the tool logic.
blasten
reviewed
Apr 27, 2020
| /// Path to the ".dart_tool" directory living under `engine/src/flutter`. | ||
| /// | ||
| /// This is a designated area for tool downloads which can be used by | ||
| /// multiple platforms. For exampe: Flutter repo for e2e tests. |
Carlos123z
reviewed
Jun 18, 2022
| import 'package:web_driver_installer/chrome_driver_installer.dart'; | ||
|
|
||
| import 'chrome_installer.dart'; | ||
| import 'common.dart'; |
| import 'chrome_installer.dart'; | ||
| import 'common.dart'; | ||
| import 'environment.dart'; | ||
| import 'exceptions.dart'; |
There was a problem hiding this comment.
- [ ]
Suggested change
| import 'exceptions.dart'; | |
| import 'exceptions.dart';```suggestion | |
| import 'exceptions.dart'; |
| /// tests shutdown. | ||
| final io.Directory _drivers; | ||
|
|
||
| IntegrationTestsManager(this._browser) |
| @@ -46,37 +48,49 @@ class IntegrationTestsManager { | |||
| } | |||
| } | |||
| await cleanup(); | ||
| exitCode = 1; | ||
| } | ||
| } on UsageException catch (e) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to run integration tests ion Cirrus using felt tool.
use-system-flutterif the local developer wants to use the system version.Fixes some tasks in the issue: flutter/flutter#52983