This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Partially revert Samsung keyboard force-update workaround #17391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
So from your comment on #16547, does this mean that this PR will re-introduce flutter/flutter#31512? |
Contributor
Author
|
It will reintroduce parts of that bug on some devices. flutter/flutter#31512 turned out to be a really wide bug covering a bunch of different behaviors. |
Contributor
Author
|
It looks like the new breakage is worse than the ones this fixed though, so we can revert for now. I am currently/already/in the process of exploring other approaches to resolve these bugs. |
Contributor
|
Sounds good - thanks! |
tvolkert
approved these changes
Mar 29, 2020
Contributor
|
Linking back to bug: flutter/flutter#53086 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2020
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 30, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the functional part of #16547
Leaves the testing improvements and samsung keyboard filtering portion of the original PR intact.