Disable OnServiceProtocolGetSkSLsWorks in Fuchsia#17361
Disable OnServiceProtocolGetSkSLsWorks in Fuchsia#17361fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
|
I didn't see this pending PR and landed #17367 instead to unblock LUCI. @liyuqian: For future reference, the "waiting for tree to go green" tag cannot be used to unblock LUCI and you need to force a push ignoring presubmits to break the deadlock. That other patch disables the test entirely BTW. If you think this is the more precise way of handling the failure. Feel free to revert that and land this instead (the tree will be green when that lands). |
0973b61 to
22a2340
Compare
|
@chinmaygarde : I rebased this PR. Now this PR reverts your PR so the test is only skipped on Fuchsia and still gets run on non-Fuchsia platforms. |
|
Sounds good. But the "Linux Fuchsia" presubmit is failing on the same check now. Are you sure the flag is working? |
|
@chinmaygarde : I see a different failure Will rerun and check it again. Rerun in https://ci.chromium.org/p/flutter/builders/try/Linux%20Fuchsia/6115 |
|
It looks like an infra failure but its not. Unfortunately, you have to click through to the task UI for the unit-test to see the failure. It is https://chromium-swarm.appspot.com/task?id=4b3614488e2c1610 |
22a2340 to
7afed8a
Compare
|
@chinmaygarde : you're right. The |
That unit test depends on `fml::WriteAtomically`. Such file operations does not seem to be well supported as FileTest is also disabled in Fuchsia.
7afed8a to
536edd4
Compare
|
Finally I figured out that I put the filter on the wrong test... It should be applied to |
We've all been there :) Thanks for sorting this out! |
That unit test depends on
fml::WriteAtomically. Such file operationsdoes not seem to be well supported as FileTest is also disabled in
Fuchsia.