Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Disable OnServiceProtocolGetSkSLsWorks in Fuchsia#17361

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
liyuqian:disable_fuchsia_test
Mar 30, 2020
Merged

Disable OnServiceProtocolGetSkSLsWorks in Fuchsia#17361
fluttergithubbot merged 1 commit intoflutter:masterfrom
liyuqian:disable_fuchsia_test

Conversation

@liyuqian
Copy link
Contributor

That unit test depends on fml::WriteAtomically. Such file operations
does not seem to be well supported as FileTest is also disabled in
Fuchsia.

@liyuqian liyuqian added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 27, 2020
@chinmaygarde chinmaygarde removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 27, 2020
@chinmaygarde
Copy link
Contributor

I didn't see this pending PR and landed #17367 instead to unblock LUCI. @liyuqian: For future reference, the "waiting for tree to go green" tag cannot be used to unblock LUCI and you need to force a push ignoring presubmits to break the deadlock.

That other patch disables the test entirely BTW. If you think this is the more precise way of handling the failure. Feel free to revert that and land this instead (the tree will be green when that lands).

@liyuqian liyuqian force-pushed the disable_fuchsia_test branch 2 times, most recently from 0973b61 to 22a2340 Compare March 27, 2020 18:01
@liyuqian liyuqian requested a review from chinmaygarde March 27, 2020 18:02
@liyuqian
Copy link
Contributor Author

@chinmaygarde : I rebased this PR. Now this PR reverts your PR so the test is only skipped on Fuchsia and still gets run on non-Fuchsia platforms.

@chinmaygarde
Copy link
Contributor

Sounds good. But the "Linux Fuchsia" presubmit is failing on the same check now. Are you sure the flag is working?

@liyuqian
Copy link
Contributor Author

liyuqian commented Mar 27, 2020

@chinmaygarde : I see a different failure

Infra Failure
recipe infra failure: Swarming task failed: (…) [03682.737324][12214][12216][pkg-resolver] ERROR: ../../src/sys/pkg/bin/pkg-resolver/src/repository/updating_tuf_client.rs(288): AutoClient for "http://192.168.42.1:33633/auto" event stream read error: NextChunk(Error { kind: Body, cause: Custom { kind: UnexpectedEof, error: "Unexpected eof during chunk size line" } }) [03682.756256][12214][12216][pkg-resolver] ERROR: ../../src/sys/pkg/bin/pkg-resolver/src/repository_manager.rs(258): while fetching package fuchsia-pkg://eb4c071e-62aa-425d-aef5-883e925d50ae/log_listener_shell/0 using rust tuf: while looking up merkle root for package: the package was not found in the repository

==================================== STDERR ====================================

==================================== STDOUT ====================================

==================================== STDERR ====================================

Will rerun and check it again. Rerun in https://ci.chromium.org/p/flutter/builders/try/Linux%20Fuchsia/6115

@chinmaygarde
Copy link
Contributor

It looks like an infra failure but its not. Unfortunately, you have to click through to the task UI for the unit-test to see the failure. It is https://chromium-swarm.appspot.com/task?id=4b3614488e2c1610

@liyuqian liyuqian force-pushed the disable_fuchsia_test branch from 22a2340 to 7afed8a Compare March 27, 2020 21:42
@liyuqian
Copy link
Contributor Author

@chinmaygarde : you're right. The gtest_filter doesn't seem to work as expected. Let me try to spell the full name of the test and see if that helps.

That unit test depends on `fml::WriteAtomically`. Such file operations
does not seem to be well supported as FileTest is also disabled in
Fuchsia.
@liyuqian liyuqian force-pushed the disable_fuchsia_test branch from 7afed8a to 536edd4 Compare March 27, 2020 23:03
@liyuqian
Copy link
Contributor Author

Finally I figured out that I put the filter on the wrong test... It should be applied to shell_tests instead of fml_tests.

@gw280
Copy link
Contributor

gw280 commented Mar 30, 2020

Finally I figured out that I put the filter on the wrong test... It should be applied to shell_tests instead of fml_tests.

We've all been there :) Thanks for sorting this out!

@liyuqian liyuqian added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 30, 2020
@fluttergithubbot fluttergithubbot merged commit 193bb35 into flutter:master Mar 30, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 30, 2020
@liyuqian liyuqian deleted the disable_fuchsia_test branch March 30, 2020 23:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects: tests cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants