Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Comments

Roll src/third_party/dart bc53ecefae52..f6acefa078be (4 commits)#17344

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
skia-flutter-autoroll:dart-sdk-flutter-engine
Mar 26, 2020
Merged

Roll src/third_party/dart bc53ecefae52..f6acefa078be (4 commits)#17344
fluttergithubbot merged 1 commit intoflutter:masterfrom
skia-flutter-autoroll:dart-sdk-flutter-engine

Conversation

@skia-flutter-autoroll
Copy link
Contributor

https://dart.googlesource.com/sdk.git/+log/bc53ecefae52..f6acefa078be

git log bc53ece..f6acefa --date=short --first-parent --format='%ad %ae %s'
2020-03-26 karlklose@google.com [infra] Ensure configuration names for custom test-runner steps are valid
2020-03-26 mfairhurst@google.com [nnbd_migration] Handle removing language comments after other comments
2020-03-26 mfairhurst@google.com [analyzer] Add an API to get a language comment token off a unit.
2020-03-26 asiva@google.com Revert "[VM] - Delete non-nullable-flag() function and adjust code that was"

Created with:
gclient setdep -r src/third_party/dart@f6acefa078be

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com

https://dart.googlesource.com/sdk.git/+log/bc53ecefae52..f6acefa078be

git log bc53ece..f6acefa --date=short --first-parent --format='%ad %ae %s'
2020-03-26 karlklose@google.com [infra] Ensure configuration names for custom test-runner steps are valid
2020-03-26 mfairhurst@google.com [nnbd_migration] Handle removing language comments after other comments
2020-03-26 mfairhurst@google.com [analyzer] Add an API to get a language comment token off a unit.
2020-03-26 asiva@google.com Revert "[VM] - Delete non-nullable-flag() function and adjust code that was"

Created with:
  gclient setdep -r src/third_party/dart@f6acefa078be

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
@skia-flutter-autoroll skia-flutter-autoroll added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 26, 2020
@fluttergithubbot fluttergithubbot merged commit c71edb1 into flutter:master Mar 26, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants