This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll src/third_party/dart ba8baa46b452..0296286c03f6 (11 commits) #17226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://dart.googlesource.com/sdk.git/+log/ba8baa46b452..0296286c03f6 git log ba8baa4..0296286 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 [email protected] [nnbd] Fix remaining analyzer issues in dart:io and dart:_http. 2020-03-20 [email protected] quickfix for `prefer_const_constructors_in_immutables` 2020-03-20 [email protected] [cfe] Don't include Function in Class.supertype and Class.implementedTypes 2020-03-20 [email protected] Issue 41095. Update flatten() to null safety. 2020-03-20 [email protected] [dart2js] fix in normalization 2020-03-20 [email protected] [mirrors] Explicitly use the new signature of Object.==. 2020-03-20 [email protected] [dart2js] Fix storing non-JsObject in property. 2020-03-20 [email protected] [WATCHLISTS] Remove johnniwinther@ from dart2js watchlist 2020-03-20 [email protected] [vm/compiler] Compiler::CompileFunction can no longer fallback to Precompiler::CompileFunction 2020-03-20 [email protected] [vm/aot] Add VM entry point annotation to _CompactLinkedHashSet. 2020-03-20 [email protected] Bump DEPS for pub to include `pub outdated` Created with: gclient setdep -r src/third_party/dart@0296286c03f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: [email protected]
skia-flutter-autoroll
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 20, 2020
Contributor
|
@godofredoc @bkonyi This Dart roll broke Web tests but still went in. Is the roll not running tests? |
Contributor
|
The error is: |
Contributor
|
Actually two of the tests failed: web_tests-3-linux |
Contributor
|
I think #17238 should prevent this in the future. |
yjbanov
added a commit
to yjbanov/engine
that referenced
this pull request
Mar 21, 2020
…ter#17226)" This reverts commit 6c757f3. It broke web tests with: ``` org-dartlang-app:///test/material/icon_button_test.dart:15:7: Warning: Implementing 'Function' is deprecated. Try removing 'Function' from the 'implements' clause. class MockOnPressedFunction implements Function { ```
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dart.googlesource.com/sdk.git/+log/ba8baa46b452..0296286c03f6
git log ba8baa4..0296286 --date=short --first-parent --format='%ad %ae %s'
2020-03-20 [email protected] [nnbd] Fix remaining analyzer issues in dart:io and dart:_http.
2020-03-20 [email protected] quickfix for
prefer_const_constructors_in_immutables2020-03-20 [email protected] [cfe] Don't include Function in Class.supertype and Class.implementedTypes
2020-03-20 [email protected] Issue 41095. Update flatten() to null safety.
2020-03-20 [email protected] [dart2js] fix in normalization
2020-03-20 [email protected] [mirrors] Explicitly use the new signature of Object.==.
2020-03-20 [email protected] [dart2js] Fix storing non-JsObject in property.
2020-03-20 [email protected] [WATCHLISTS] Remove johnniwinther@ from dart2js watchlist
2020-03-20 [email protected] [vm/compiler] Compiler::CompileFunction can no longer fallback to Precompiler::CompileFunction
2020-03-20 [email protected] [vm/aot] Add VM entry point annotation to _CompactLinkedHashSet.
2020-03-20 [email protected] Bump DEPS for pub to include
pub outdatedCreated with:
gclient setdep -r src/third_party/dart@0296286c03f6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: [email protected]