This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Canvas: Remove some unused virtuals, and prepare for signature change #17135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM (but needs a run of the autoformatter - see https://github.com/flutter/engine/pull/17135/checks?check_run_id=505872936) |
Contributor
Author
|
Re-formatted, and went ahead and fully converted the vertices signatures. That won't be able to land yet, but an incoming Skia PR will make this (cleaner) version build. |
Contributor
|
That change is in skia, just needs to roll into flutter
…On Fri, Mar 13, 2020 at 10:59 AM Brian Osman ***@***.***> wrote:
Re-formatted, and went ahead and fully converted the vertices signatures.
That won't be able to land yet, but an incoming Skia PR will make this
(cleaner) version build.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#17135 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADDLXIXTZZ63UFCKVOO5HDLRHJC5BANCNFSM4LHDQNTQ>
.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bitmap virtuals are never called (and will be removed soon). The bone parameters to the vertices virtual are being removed.