This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Don't constexpr iphone_xs_times #16264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is a dupe of #15450 but this fix should work in all cases. The fix in the other PR fails where the file currently compiles (as other compilers want the lambda to be explicitly captured) |
cbracken
reviewed
Jan 30, 2020
cbracken
approved these changes
Jan 30, 2020
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
lgtm. Can you add (a) file a bug against the compiler team and (b) add a TODO that links that bug so we can revert to constexpr when the bug has been fixed in the toolchain.
Contributor
Author
|
An update, after talking with some compiler folks: Fuchsia's toolchain is much more up to date than e.g. the host toolchain on my Linux machine (11.x vs. 8.x). The compiler's behaviour here changed and the best workaround here is to use |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 31, 2020
flutter/engine@804dca6...6b8c150 git log 804dca6..6b8c150 --first-parent --oneline 2020-01-31 [email protected] Use static constexpr for iphone_xs_times (flutter/engine#16264) 2020-01-31 [email protected] Started coalescing updates to viewport metrics after foregrounding the app. (flutter/engine#16270) 2020-01-31 [email protected] Remove superfluous INFO logs from //flutter/runtime. (flutter/engine#16280) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This reverts commit cd5dff5.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clang toolchain for Fuchsia doesn't like this lambda capture to be explicit when
iphone_xs_timesis a constexpr.