Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove buggy test to check if tasks can be posted on all native threads recursively from the emebdder. #16214

Merged
chinmaygarde merged 1 commit into from
Jan 30, 2020
Merged

Remove buggy test to check if tasks can be posted on all native threads recursively from the emebdder. #16214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions shell/platform/embedder/tests/embedder_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4006,40 +4006,5 @@ TEST_F(EmbedderTest, CanPostTaskToAllNativeThreads) {
ASSERT_FALSE(engine.is_valid());
}

TEST_F(EmbedderTest, CanPostTaskToAllNativeThreadsRecursively) {
EmbedderConfigBuilder builder(GetEmbedderContext());

builder.SetSoftwareRendererConfig();

static std::mutex engine_mutex;
static UniqueEngine engine;
static fml::AutoResetWaitableEvent event;

std::unique_lock engine_lock(engine_mutex);
engine.reset();
engine = builder.LaunchEngine();
ASSERT_TRUE(engine.is_valid());
ASSERT_EQ(FlutterEnginePostCallbackOnAllNativeThreads(
engine.get(),
[](FlutterNativeThreadType type, void* baton) {
// This should deadlock if the task mutex acquisition is
// busted.
std::scoped_lock engine_lock_inner(engine_mutex);
if (engine.is_valid()) {
ASSERT_EQ(FlutterEnginePostCallbackOnAllNativeThreads(
engine.get(),
[](FlutterNativeThreadType type,
void* baton) { event.Signal(); },
nullptr),
kSuccess);
}
},
&engine),
kSuccess);
engine_lock.unlock();
event.Wait();
engine.reset();
}

} // namespace testing
} // namespace flutter