Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
cc6989b
Roll ANGLE to ToT
stuartmorgan-g Jan 21, 2020
0d455a4
Roll buildroot
stuartmorgan-g Jan 22, 2020
e3990bf
Update VS path in Cirrus config
stuartmorgan-g Jan 22, 2020
c3d2c8f
Merge branch 'master' into angle-roll
stuartmorgan-g May 1, 2020
c0b33a4
Update roll to current ToT
stuartmorgan-g May 1, 2020
17a1375
Point to temporary location of updated buildroot
stuartmorgan-g May 3, 2020
7219231
Try to weed out false positive license failures from long copyright
stuartmorgan-g Jun 1, 2020
3ff015f
Merge branch 'master' into angle-roll
stuartmorgan-g Jun 1, 2020
d4e46aa
Attempted zlib extension match
stuartmorgan-g Jun 2, 2020
9bc3389
Don't include volk, since we don't use it.
stuartmorgan-g Jun 2, 2020
c9d785c
Fix zlib extension matching
stuartmorgan-g Jun 2, 2020
d65d192
Prune out the Bison skeleton template files, since they aren't actual…
stuartmorgan-g Jun 2, 2020
46debb5
Update licenses
stuartmorgan-g Jun 2, 2020
5387886
Merge branch 'master' into angle-roll
stuartmorgan-g Jun 9, 2020
cd28651
Re-run post-merge license update with correct DEPS
stuartmorgan-g Jun 9, 2020
a8b36b1
Adjust ANGLE directory walking; nothing in tools/ is shipped
stuartmorgan-g Jun 9, 2020
325a5c1
Re-run script
stuartmorgan-g Jun 9, 2020
49924e9
Point to actual buildroot now that it's landed
stuartmorgan-g Jun 10, 2020
180a530
Merge branch 'master' into angle-roll
stuartmorgan-g Jun 10, 2020
d8b48a6
Merge remote-tracking branch 'origin/angle-roll' into angle-roll
stuartmorgan-g Jun 10, 2020
52c6c62
Signature mismatch with CI
stuartmorgan-g Jun 10, 2020
d480eed
Merge branch 'master' into angle-roll
stuartmorgan-g Jun 10, 2020
1daee63
Chasing the moving target
stuartmorgan-g Jun 10, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ allowed_hosts = [
]

deps = {
'src': 'https://github.com/flutter/buildroot.git' + '@' + '6669621484b649b9355fb2dd37950daf3d2ac65b',
'src': 'https://github.com/flutter/buildroot.git' + '@' + 'd00ecf066669b2d6b3f9174de581864655bce6ff',

# Fuchsia compatibility
#
Expand Down Expand Up @@ -396,7 +396,7 @@ deps = {
Var('swiftshader_git') + '/SwiftShader.git' + '@' + '5d1e8540407c138f47028d64684f3da599430aa4',

'src/third_party/angle':
Var('github_git') + '/google/angle.git' + '@' + '3ea90d609720b7b9b9d05ca094860382f2425294',
Var('github_git') + '/google/angle.git' + '@' + 'a56537a3d83d2eb4be6d1ae1ea074698850b1fa8',

'src/third_party/pkg/when':
Var('dart_git') + '/when.git' + '@' + '0.2.0',
Expand Down
1,592 changes: 1,002 additions & 590 deletions ci/licenses_golden/licenses_third_party

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ci/licenses_golden/tool_signature
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Signature: c182c713338fa4bfd82bfab82778038b
Signature: c945496402c0b0e15ef05052f6619caa

465 changes: 284 additions & 181 deletions sky/packages/sky_engine/LICENSE

Large diffs are not rendered by default.

14 changes: 12 additions & 2 deletions tools/licenses/lib/licenses.dart
Original file line number Diff line number Diff line change
Expand Up @@ -738,8 +738,18 @@ Iterable<_PartialLicenseMatch> _findLicenseBlocks(String body, RegExp pattern, i
// examined closer.
final _SplitLicense sanityCheck = _splitLicense(undecoratedCopyrights, verifyResults: false);
final String conditions = sanityCheck.getConditions();
if (conditions != '')
throw 'potential license text caught in _findLicenseBlocks copyright dragnet:\n---\n$conditions\n---\nundecorated copyrights was:\n---\n$undecoratedCopyrights\n---\ncopyrights was:\n---\n$copyrights\n---\nblock was:\n---\n${body.substring(start, match.end)}\n---';
if (conditions != '') {
// Copyright lines long enough to spill to a second line can create
// false positives; try to weed those out.
final String resplitCopyright = sanityCheck.getCopyright();
if (resplitCopyright.trim().contains('\n') ||
conditions.trim().contains('\n') ||
resplitCopyright.length < 70 ||
conditions.length > 15) {
throw 'potential license text caught in _findLicenseBlocks copyright dragnet:\n---\n$conditions\n---\nundecorated copyrights was:\n---\n$undecoratedCopyrights\n---\ncopyrights was:\n---\n$copyrights\n---\nblock was:\n---\n${body.substring(start, match.end)}\n---';
}
}

if (!copyrights.contains(copyrightMentionPattern))
throw 'could not find copyright before license block:\n---\ncopyrights was:\n---\n$copyrights\n---\nblock was:\n---\n${body.substring(start, match.end)}\n---';
if (body[match.start - 1] != '\n')
Expand Down
40 changes: 40 additions & 0 deletions tools/licenses/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1304,6 +1304,44 @@ class _RepositoryExcludeSubpathDirectory extends _RepositoryDirectory {

// WHAT TO CRAWL AND WHAT NOT TO CRAWL

class _RepositoryAngleDirectory extends _RepositoryDirectory {
_RepositoryAngleDirectory(_RepositoryDirectory parent, fs.Directory io) : super(parent, io);

@override
_RepositoryDirectory createSubdirectory(fs.Directory entry) {
if (entry.name == 'src')
return _RepositoryAngleSrcDirectory(this, entry);
return super.createSubdirectory(entry);
}

@override
bool shouldRecurse(fs.IoNode entry) {
return entry.name != 'tools' // These are build-time tools, and aren't shipped.
&& super.shouldRecurse(entry);
}
}

class _RepositoryAngleSrcDirectory extends _RepositoryDirectory {
_RepositoryAngleSrcDirectory(_RepositoryDirectory parent, fs.Directory io) : super(parent, io);

@override
_RepositoryDirectory createSubdirectory(fs.Directory entry) {
if (entry.name == 'third_party')
return _RepositoryAngleSrcThirdPartyDirectory(this, entry);
return super.createSubdirectory(entry);
}
}

class _RepositoryAngleSrcThirdPartyDirectory extends _RepositoryDirectory {
_RepositoryAngleSrcThirdPartyDirectory(_RepositoryDirectory parent, fs.Directory io) : super(parent, io);

@override
bool shouldRecurse(fs.IoNode entry) {
return entry.name != 'volk' // We don't use Vulkan in our ANGLE build.
&& super.shouldRecurse(entry);
}
}

class _RepositoryAndroidPlatformDirectory extends _RepositoryDirectory {
_RepositoryAndroidPlatformDirectory(_RepositoryDirectory parent, fs.Directory io) : super(parent, io);

Expand Down Expand Up @@ -1763,6 +1801,8 @@ class _RepositoryRootThirdPartyDirectory extends _RepositoryGenericThirdPartyDir
_RepositoryDirectory createSubdirectory(fs.Directory entry) {
if (entry.name == 'android_platform')
return _RepositoryAndroidPlatformDirectory(this, entry);
if (entry.name == 'angle')
return _RepositoryAngleDirectory(this, entry);
if (entry.name == 'boringssl')
return _RepositoryBoringSSLDirectory(this, entry);
if (entry.name == 'catapult')
Expand Down
17 changes: 17 additions & 0 deletions tools/licenses/lib/patterns.dart
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,23 @@ final List<LicenseFileReferencePattern> csReferencesByFilename = <LicenseFileRef
)
),

// Chromium's zlib extensions.
LicenseFileReferencePattern(
firstPrefixIndex: 1,
indentPrefixIndex: 2,
copyrightIndex: 3,
authorIndex: 4,
fileIndex: 5,
pattern: RegExp(
kIndent +
r'(Copyright .+(The .+ Authors)\. +All rights reserved\. *\n)' +
r'\1\2Use of this source code is governed by a BSD-style license that can be *\n'
r'\1\2found in the Chromium source repository ([^ ]+) file.',
multiLine: true,
caseSensitive: false,
)
),

// Mojo code
LicenseFileReferencePattern(
firstPrefixIndex: 1,
Expand Down