This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] edge launcher for windows #15690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
reviewed
Jan 16, 2020
added 2 commits
January 16, 2020 10:40
yjbanov
approved these changes
Jan 16, 2020
added 2 commits
January 16, 2020 11:06
Contributor
Author
|
I'll continue with the merge since only LUCI tests have an exception and the PR is only about web tooling for windows. Hopefully the run triggered with this PR will make the tree green. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 17, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 17, 2020
flutter/engine@839b34c...0427416 git log 839b34c..0427416 --first-parent --oneline 2020-01-16 [email protected] Fix Opacity performance regression on Fuchsia (flutter/engine#15573) 2020-01-16 [email protected] [web] edge launcher for windows (flutter/engine#15690) 2020-01-16 [email protected] [web] Add BoxHeightStyle.strut (flutter/engine#15694) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
* edge launcher for windows * addressing PR comments * url mistake * remove uncessary import * initialization error fix * format
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This reverts commit c850393.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
* edge launcher for windows * addressing PR comments * url mistake * remove uncessary import * initialization error fix * format
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to launch edge on windows from command line or from a batch script we are using the following github project:
https://github.com/MicrosoftEdge/edge-launcher
Fixes: flutter/flutter#48823