This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support Clipboard.getData and Clipboard.setData for Flutter for web #15455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturgut
changed the title
mdebbar
reviewed
Jan 10, 2020
nturgut
force-pushed
the
clipboard_api_imp
branch
from
05904f5 to
e3aebe5
Compare
nturgut
added
the
waiting for tree to go green
Contributor
Author
|
Merging the code since the breakage is in Fuchsia. The PR is about Clipboard support in Flutter for Web. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 13, 2020
flutter/engine@3d37d39...88935ca git log 3d37d39..88935ca --first-parent --oneline 2020-01-11 [email protected] Support Clipboard.getData and Clipboard.setData for Flutter for web (flutter/engine#15455) 2020-01-11 [email protected] Roll src/third_party/dart 395daaa3ecfc..b3457c8cc2c1 (66 commits) (flutter/engine#15485) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
mehere
pushed a commit
to mehere/flutter
that referenced
this pull request
Jan 14, 2020
flutter/engine@3d37d39...88935ca git log 3d37d39..88935ca --first-parent --oneline 2020-01-11 [email protected] Support Clipboard.getData and Clipboard.setData for Flutter for web (flutter/engine#15455) 2020-01-11 [email protected] Roll src/third_party/dart 395daaa3ecfc..b3457c8cc2c1 (66 commits) (flutter/engine#15485) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
11 tasks
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…lutter#15455) * copy/paste solution for chrome. copy solution for firefox. using clipboardAPI. * addressing PR comments * update licences file
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…or web (flutter#15455)" This reverts commit f9b0432.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
…lutter#15455) * copy/paste solution for chrome. copy solution for firefox. using clipboardAPI. * addressing PR comments * update licences file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy/paste solution for chrome. copy solution for firefox. Implemented using clipboardAPI
See:https://developers.google.com/web/updates/2018/03/clipboardapi
See: https://developer.mozilla.org/en-US/docs/Web/API/Clipboard
firefox can only use readText if the target is an editable content. we can use execCommand instead, will continue in issue: flutter/flutter#48581
Fixes: flutter/flutter#46020