Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Jan 9, 2020

From the onNewIntent docs:

If you are handling new intents and may be making changes to the
fragment state, you want to be sure to call through to the
super-class here first. Otherwise, if your state is saved but the
activity is not stopped, you could get an onNewIntent() call which
happens before onResume() and trying to perform fragment operations
at that point will throw IllegalStateException because the fragment
manager thinks the state is still saved.

From the onNewIntent docs:

    If you are handling new intents and may be making changes to the
    fragment state, you want to be sure to call through to the
    super-class here first. Otherwise, if your state is saved but the
    activity is not stopped, you could get an onNewIntent() call which
    happens before onResume() and trying to perform fragment operations
    at that point will throw IllegalStateException because the fragment
    manager thinks the state is still saved.
@cbracken
Copy link
Member Author

cbracken commented Jan 9, 2020

Identified by internal tooling as part of a large-scale change in google3.

@cbracken cbracken merged commit 5c9e134 into flutter:master Jan 9, 2020
@cbracken cbracken deleted the missing-super-call branch January 9, 2020 02:07
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 11, 2020
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
From the onNewIntent docs:

    If you are handling new intents and may be making changes to the
    fragment state, you want to be sure to call through to the
    super-class here first. Otherwise, if your state is saved but the
    activity is not stopped, you could get an onNewIntent() call which
    happens before onResume() and trying to perform fragment operations
    at that point will throw IllegalStateException because the fragment
    manager thinks the state is still saved.
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
From the onNewIntent docs:

    If you are handling new intents and may be making changes to the
    fragment state, you want to be sure to call through to the
    super-class here first. Otherwise, if your state is saved but the
    activity is not stopped, you could get an onNewIntent() call which
    happens before onResume() and trying to perform fragment operations
    at that point will throw IllegalStateException because the fragment
    manager thinks the state is still saved.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants