Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

modify test_runner.dart for windows to fix test build errors #15326

Merged
fluttergithubbot merged 3 commits into from
Jan 9, 2020
Merged

modify test_runner.dart for windows to fix test build errors #15326

fluttergithubbot merged 3 commits into from
Jan 9, 2020

Conversation

@nturgut
Copy link
Contributor

@nturgut nturgut commented Jan 9, 2020 •
edited
Loading

Felt was not able to build tests on Windows.

The following changes fixes the problem:

  1. Running the process in a system shell. (otherwise it is not able to get dart from path. I used this tool to track the error https://docs.microsoft.com/en-us/sysinternals/downloads/procmon)
  2. Running pub get before starting pub run. My guess is it is related to the issue: No .dart_tool/package_config.json file found when running build_runner dart-lang/pub#2241 (there is also this issue reported for Dart 2.7+ Unable to run unit tests when pubspec uses Path packages on Dart 2.7 or greater dart-lang/sdk#39738)

related: flutter/flutter#48456

@nturgut nturgut added the platform-web Code specifically for the web engine label Jan 9, 2020
@nturgut nturgut requested a review from yjbanov January 9, 2020 00:18
@auto-assign auto-assign bot requested a review from stuartmorgan-g January 9, 2020 00:18
@nturgut nturgut removed the request for review from stuartmorgan-g January 9, 2020 00:19
yjbanov
yjbanov approved these changes Jan 9, 2020
View reviewed changes
@nturgut nturgut added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 9, 2020
@fluttergithubbot fluttergithubbot merged commit 94c5b9f into flutter:master Jan 9, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
94c5b9f modify test_runner.dart for windows to fix test build errors (f…
8d046aa 
…lutter/engine#15326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
94c5b9f modify test_runner.dart for windows to fix test build errors (f…
184eb69 
…lutter/engine#15326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
94c5b9f modify test_runner.dart for windows to fix test build errors (f…
8ffd687 
…lutter/engine#15326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
94c5b9f modify test_runner.dart for windows to fix test build errors (f…
8452711 
…lutter/engine#15326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
94c5b9f modify test_runner.dart for windows to fix test build errors (f…
e002b42 
…lutter/engine#15326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
94c5b9f modify test_runner.dart for windows to fix test build errors (f…
a120b9b 
…lutter/engine#15326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
94c5b9f modify test_runner.dart for windows to fix test build errors (f…
54c2b11 
…lutter/engine#15326)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
@engine-flutter-autoroll
94c5b9f modify test_runner.dart for windows to fix test build errors (f…
19de419 
…lutter/engine#15326)
@GaryQian GaryQian mentioned this pull request Jan 10, 2020
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 11, 2020
@engine-flutter-autoroll
94c5b9f modify test_runner.dart for windows to fix test build errors (f…
3960bb6 
…lutter/engine#15326)
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@NoamDev
modify test_runner.dart for windows to fix test build errors (flutter…
2aa4f7a 
…#15326)
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@NoamDev
Revert "modify test_runner.dart for windows to fix test build errors (f…
8e06ab5 
…lutter#15326)"

This reverts commit 2aa4f7a.
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
@filmil
modify test_runner.dart for windows to fix test build errors (flutter…
4b0c51b 
…#15326)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nturgut @yjbanov @googlebot @fluttergithubbot