This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add plugin_registrar_windows.h to published wrapper #15265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was missed in the wrapper publishing during the switch to the Win32 embedding, so it's not part of the wrapper package that is available to clients. This adds it to the published wrapper, as originally intended.
franciscojma86
approved these changes
Jan 8, 2020
stuartmorgan-g
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 8, 2020
flutter/engine@a50f1ef...4e9e69d git log a50f1ef..4e9e69d --first-parent --oneline 2020-01-08 [email protected] Roll fuchsia/sdk/core/mac-amd64 from nbeLe... to gL-XG... (flutter/engine#15253) 2020-01-08 [email protected] Add plugin_registrar_windows.h to published wrapper (flutter/engine#15265) 2020-01-08 [email protected] Roll src/third_party/dart bebc7d3af5bd..c0ca187f2699 (37 commits) (flutter/engine#15252) 2020-01-08 [email protected] Roll fuchsia/sdk/core/linux-amd64 from xYmDF... to oNKzr... (flutter/engine#15257) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
bkonyi
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 9, 2020
flutter/engine@a50f1ef...4e9e69d git log a50f1ef..4e9e69d --first-parent --oneline 2020-01-08 [email protected] Roll fuchsia/sdk/core/mac-amd64 from nbeLe... to gL-XG... (flutter/engine#15253) 2020-01-08 [email protected] Add plugin_registrar_windows.h to published wrapper (flutter/engine#15265) 2020-01-08 [email protected] Roll src/third_party/dart bebc7d3af5bd..c0ca187f2699 (37 commits) (flutter/engine#15252) 2020-01-08 [email protected] Roll fuchsia/sdk/core/linux-amd64 from xYmDF... to oNKzr... (flutter/engine#15257) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file was missed in the wrapper publishing during the switch to the
Win32 embedding, so it's not part of the wrapper package that is
available to clients. This adds it to the published wrapper, as
originally intended.