This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] fix selection issue #14604
Merged
[web] fix selection issue #14604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
approved these changes
Dec 23, 2019
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the quick fix!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 26, 2019
This was referenced Dec 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 26, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Dec 26, 2019
flutter/engine@42bb7c9...dc0187f git log 42bb7c9..dc0187f --first-parent --oneline 2019-12-24 [email protected] Roll src/third_party/dart 8736fec094bb..75fc15c7e186 (6 commits) (flutter/engine#14679) 2019-12-24 [email protected] Run and collect benchmarks (flutter/engine#14556) 2019-12-23 [email protected] Roll src/third_party/dart 4a639e8df261..8736fec094bb (11 commits) (flutter/engine#14678) 2019-12-23 [email protected] Roll src/third_party/skia ac29f1342fd2..a2d7225c0fc1 (5 commits) (flutter/engine#14677) 2019-12-23 [email protected] fix selection issue (flutter/engine#14604) 2019-12-23 [email protected] Roll fuchsia/sdk/core/linux-amd64 from TUoVa... to v3R8A... (flutter/engine#14670) 2019-12-23 [email protected] Roll src/third_party/dart cfca5ea9f2e9..4a639e8df261 (7 commits) (flutter/engine#14671) 2019-12-23 [email protected] Roll src/third_party/skia 6ec826085b2a..ac29f1342fd2 (1 commits) (flutter/engine#14672) 2019-12-23 [email protected] Roll fuchsia/sdk/core/mac-amd64 from IZ278... to ZA31z... (flutter/engine#14675) 2019-12-21 [email protected] Roll src/third_party/dart 1db1a837f8c9..cfca5ea9f2e9 (2 commits) (flutter/engine#14667) 2019-12-21 [email protected] Roll src/third_party/skia 2723af6a6d43..6ec826085b2a (3 commits) (flutter/engine#14665) 2019-12-21 [email protected] Roll src/third_party/dart c260e4e8dac6..1db1a837f8c9 (8 commits) (flutter/engine#14606) 2019-12-21 [email protected] Roll src/third_party/skia 28b0c5d4b3bb..2723af6a6d43 (4 commits) (flutter/engine#14605) 2019-12-20 [email protected] View ref pair (flutter/engine#14602) 2019-12-20 [email protected] Roll fuchsia/sdk/core/mac-amd64 from VC7eE... to IZ278... (flutter/engine#14603) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 28, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Dec 28, 2019
flutter/engine@5a730c6...bdc9708 git log 5a730c6..bdc9708 --first-parent --oneline 2019-12-28 [email protected] Revert "Use ELF for Dart AOT snapshots on Fuchsia. (#13896)" (flutter/engine#14823) 2019-12-27 [email protected] Roll src/third_party/skia 89bf1547f3aa..5a2f962313a5 (16 commits) (flutter/engine#14825) 2019-12-27 [email protected] Roll fuchsia/sdk/core/linux-amd64 from ikxBh... to sxapd... (flutter/engine#14821) 2019-12-27 [email protected] Roll fuchsia/sdk/core/mac-amd64 from IEPKx... to iImpF... (flutter/engine#14817) 2019-12-27 [email protected] Roll src/third_party/dart 94a4f6415e6c..c547f5d933e5 (9 commits) (flutter/engine#14812) 2019-12-27 [email protected] Roll src/third_party/skia f2d522a3f434..89bf1547f3aa (4 commits) (flutter/engine#14814) 2019-12-26 [email protected] Roll src/third_party/dart 232a171a0b1c..94a4f6415e6c (8 commits) (flutter/engine#14808) 2019-12-26 [email protected] Roll src/third_party/skia 07d744fb8a53..f2d522a3f434 (4 commits) (flutter/engine#14807) 2019-12-26 [email protected] Roll src/third_party/skia 05eb83be171c..07d744fb8a53 (3 commits) (flutter/engine#14806) 2019-12-26 [email protected] Roll fuchsia/sdk/core/linux-amd64 from v3R8A... to ikxBh... (flutter/engine#14802) 2019-12-26 [email protected] Roll src/third_party/dart 75fc15c7e186..232a171a0b1c (4 commits) (flutter/engine#14803) 2019-12-26 [email protected] Roll fuchsia/sdk/core/mac-amd64 from ZA31z... to IEPKx... (flutter/engine#14702) 2019-12-26 [email protected] Roll src/third_party/skia 3d3150c89c5f..05eb83be171c (3 commits) (flutter/engine#14800) 2019-12-24 [email protected] Roll src/third_party/skia a2d7225c0fc1..3d3150c89c5f (1 commits) (flutter/engine#14680) 2019-12-24 [email protected] Roll src/third_party/dart 8736fec094bb..75fc15c7e186 (6 commits) (flutter/engine#14679) 2019-12-24 [email protected] Run and collect benchmarks (flutter/engine#14556) 2019-12-23 [email protected] Roll src/third_party/dart 4a639e8df261..8736fec094bb (11 commits) (flutter/engine#14678) 2019-12-23 [email protected] Roll src/third_party/skia ac29f1342fd2..a2d7225c0fc1 (5 commits) (flutter/engine#14677) 2019-12-23 [email protected] fix selection issue (flutter/engine#14604) 2019-12-23 [email protected] Roll fuchsia/sdk/core/linux-amd64 from TUoVa... to v3R8A... (flutter/engine#14670) 2019-12-23 [email protected] Roll src/third_party/dart cfca5ea9f2e9..4a639e8df261 (7 commits) (flutter/engine#14671) 2019-12-23 [email protected] Roll src/third_party/skia 6ec826085b2a..ac29f1342fd2 (1 commits) (flutter/engine#14672) 2019-12-23 [email protected] Roll fuchsia/sdk/core/mac-amd64 from IZ278... to ZA31z... (flutter/engine#14675) 2019-12-21 [email protected] Roll src/third_party/dart 1db1a837f8c9..cfca5ea9f2e9 (2 commits) (flutter/engine#14667) 2019-12-21 [email protected] Roll src/third_party/skia 2723af6a6d43..6ec826085b2a (3 commits) (flutter/engine#14665) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
|
The problem is still there. How can I make sure he's fixed |
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mouse selection by the browser was colliding with the selection synced from flutter which was creating a flickering.
the PR is preventing default for mouse up, down, move which fixes the issue. Fix does not change IOS and Android strategies.
Tested on: Chrome on linux, Firefox on Linux.
fixes: flutter/flutter#45848