This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] adding firefox unit tests to font loading #14467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturgut
added
the
waiting for tree to go green
Contributor
Author
|
Merging this one. This file is only adding more unit tests, no change in code behavior. |
nturgut
removed
the
waiting for tree to go green
yjbanov
reviewed
Dec 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2019
This was referenced Dec 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2019
franciscojma86
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 17, 2019
* 7922bc8 [web] adding firefox unit tests to font loading (flutter/engine#14467) * 4ca54fe Roll src/third_party/dart c561a9eacc1b..fe9f30c3896e (7 commits) (flutter/engine#14475) * b616dcd Roll fuchsia/sdk/core/linux-amd64 from sBbWo... to QZVxo... (flutter/engine#14473) * 1377ef6 Roll src/third_party/skia c514e7d9be6e..d0840ecf5831 (18 commits) (flutter/engine#14478) * bdd4e4d Do not assume that createTypeface is called before getStyle in the AssetManagerFontStyleSet (flutter/engine#14343)
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
* adding firefox unit tests to font loading * reviewer suggestions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter web engine unit tests is running on firefox (as an addition to chrome) with PR: #14267
The following tests were skipped on Firefox since they were failing:
test/text/font_collection_test.dart: FontManager Register Asset twice with special character slash
test/text/font_collection_test.dart: FontManager Register Asset twice with exclamation mark
test/text/font_collection_test.dart: FontManager Register Asset twice with coma
test/text/font_collection_test.dart: FontManager Register Asset twice with a digit at the start of a token
The failure was legitimate since the loading was handled differently for Firefox. Added a new group of tests to test Firefox and skipped the other group.
Related: flutter/flutter#46638