Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix for tab not working #14165

Merged
nturgut merged 4 commits into from
Dec 10, 2019
Merged

Fix for tab not working #14165

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4af8eac
some logs
Dec 6, 2019
f85ebb5
Masking moddifier state for lock keys if the key code is not the same…
Dec 7, 2019
be94fef
removing modifier state for locks
Dec 10, 2019
101b723
addresing pr comments'
Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions lib/web_ui/lib/src/engine/keyboard.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@ const int _modifierShift = 0x01;
const int _modifierAlt = 0x02;
const int _modifierControl = 0x04;
const int _modifierMeta = 0x08;
const int _modifierNumLock = 0x10;
const int _modifierCapsLock = 0x20;
const int _modifierScrollLock = 0x40;

/// Creates a bitmask representing the meta state of the [event].
int _getMetaState(html.KeyboardEvent event) {
Expand All @@ -136,15 +133,8 @@ int _getMetaState(html.KeyboardEvent event) {
if (event.getModifierState('Meta')) {
metaState |= _modifierMeta;
}
if (event.getModifierState('NumLock')) {
metaState |= _modifierNumLock;
}
if (event.getModifierState('CapsLock')) {
metaState |= _modifierCapsLock;
}
if (event.getModifierState('ScrollLock')) {
metaState |= _modifierScrollLock;
}
// TODO: Re-enable lock key modifiers once there is support on Flutter
// Framework. https://github.com/flutter/flutter/issues/46718
return metaState;
}

Expand Down