This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] SnapToNextPhase refactor + add tests and documentation #14158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
force-pushed
the
add-better-docs-for-snap
branch
from
f68718b to
776c7c5
Compare
gw280
reviewed
Dec 6, 2019
| if (delta < presentation_interval) { | ||
| return last_frame_presentation_time + presentation_interval; | ||
| } else { | ||
| int64_t num_phases_passed = delta / presentation_interval; |
Contributor
Author
There was a problem hiding this comment.
not sure it matters here since the overloaded division operator in TimeDelta is int64_t though as you point out it ought to be unsigned. Leaving this as is for now.
| /// will be the same. | ||
| /// | ||
| /// Scenario 1: | ||
| /// presentation_interval is 2 |
Contributor
There was a problem hiding this comment.
can we clarify here that presentation_interval is a time delta, not the number of frames
Contributor
Author
There was a problem hiding this comment.
The type of the param is fml::TimeDelta as opposed to an integral type, so this should be clear once the reader gets to the method definition.
| } else { | ||
| int64_t num_phases_passed = delta / presentation_interval; | ||
| // this is to ensure that we will be past the "now" time point. | ||
| if (delta % presentation_interval == fml::TimeDelta::Zero()) { |
Contributor
There was a problem hiding this comment.
I'm not sure I fully understand this. I think it's supposed to be iterating over to the first future timepoint at which a presentation is scheduled to occur, so e.g. if we have a delta of 20ms since the last presentation, and the presentation interval is 16ms, we're 4ms into the budget for the n+1 frame, which means we need to return a timepoint 12ms in the future from now, is this correct?
In this expression, 20 % 16 != 0 so we won't be adding to the phases passed, and the integer division above should return the floor so we'd be returning a timepoint in the past?
last_frame_presentation_time = 0
presentation_interval = 16
now = 20
delta = 20
num_phases_passed = 20 / 16 = 1
delta % presentation_interval = 20 % 16 = 4
return 0 + (16 * 1) = 16?
Contributor
Author
There was a problem hiding this comment.
I meant to do a ceil and was accounting for the case where there is a perfect division. good catch, will add a test for this.
iskakaushik
force-pushed
the
add-better-docs-for-snap
branch
from
776c7c5 to
bf40301
Compare
chinmaygarde
reviewed
Dec 6, 2019
gw280
approved these changes
Dec 6, 2019
Contributor
gw280
left a comment
gw280
left a comment
There was a problem hiding this comment.
LGTM with Chinmay's comments
iskakaushik
force-pushed
the
add-better-docs-for-snap
branch
from
bf40301 to
3fc2e37
Compare
iskakaushik
force-pushed
the
add-better-docs-for-snap
branch
from
3fc2e37 to
a957ba3
Compare
iskakaushik
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2019
This was referenced Dec 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2019
This was referenced Dec 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2019
This was referenced Dec 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2019
This was referenced Dec 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Dec 9, 2019
flutter/engine@e7b69ce...5b870a2 git log e7b69ce..5b870a2 --first-parent --oneline 2019-12-08 [email protected] Add support for setting window size limits for glfw (flutter/engine#13415) 2019-12-06 [email protected] [fuchsia] SnapToNextPhase refactor + add tests and documentation (flutter/engine#14158) 2019-12-06 [email protected] Roll fuchsia/sdk/core/mac-amd64 from VKso5... to 9C6UA... (flutter/engine#14161) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.