This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] [test] Adding firefox install functionality to the test platform #13272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2019 16:15
…. Refactor test platform code
yjbanov
reviewed
Oct 22, 2019
Contributor
yjbanov
left a comment
yjbanov
left a comment
There was a problem hiding this comment.
LGTM, but now that there's a non-trivial amount of code, let's add a test to Cirrus that exercises this code.
nturgut
commented
Oct 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 24, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 24, 2019
[email protected]:flutter/engine.git/compare/195425e04480...400e3b0 git log 195425e..400e3b0 --no-merges --oneline 2019-10-23 [email protected] Wires the locale provided by Fuchsia. (flutter/engine#13045) 2019-10-23 [email protected] Add FlutterEngineRunsAOTCompiledDartCode to the embedder API. (flutter/engine#13319) 2019-10-23 [email protected] [web] [test] Adding firefox install functionality to the test platform (flutter/engine#13272) 2019-10-23 [email protected] Roll src/third_party/skia 32803ff74448..6863bb0930cf (7 commits) (flutter/engine#13318) 2019-10-23 [email protected] Roll src/third_party/dart 5fd6c8a3c1..b359ac0a1e (2 commits) 2019-10-23 [email protected] [recipe] Upload opt flutter_tester (flutter/engine#13311) 2019-10-23 [email protected] Update the dependencies for the Fuchsia build of flutter_frontend_server (flutter/engine#13316) 2019-10-23 [email protected] NO_SUGGESTIONS keyboard flag in Android (flutter/engine#13099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/195425e04480...400e3b0 git log 195425e..400e3b0 --no-merges --oneline 2019-10-23 [email protected] Wires the locale provided by Fuchsia. (flutter/engine#13045) 2019-10-23 [email protected] Add FlutterEngineRunsAOTCompiledDartCode to the embedder API. (flutter/engine#13319) 2019-10-23 [email protected] [web] [test] Adding firefox install functionality to the test platform (flutter/engine#13272) 2019-10-23 [email protected] Roll src/third_party/skia 32803ff74448..6863bb0930cf (7 commits) (flutter/engine#13318) 2019-10-23 [email protected] Roll src/third_party/dart 5fd6c8a3c1..b359ac0a1e (2 commits) 2019-10-23 [email protected] [recipe] Upload opt flutter_tester (flutter/engine#13311) 2019-10-23 [email protected] Update the dependencies for the Fuchsia build of flutter_frontend_server (flutter/engine#13316) 2019-10-23 [email protected] NO_SUGGESTIONS keyboard flag in Android (flutter/engine#13099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Firefox installing functionality to test platform. For Linux only.
I also refactored test_platform.dart and took chrome related parts to chrome.dart.