This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fixing selection issues in Firefox #12793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Oct 4, 2019
mdebbar
approved these changes
Oct 4, 2019
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
LGTM with minor comments.
mdebbar
reviewed
Oct 4, 2019
fixing typo
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 7, 2019
[email protected]:flutter/engine.git/compare/7d90779bb66f...1d62160 git log 7d90779..1d62160 --no-merges --oneline 2019-10-04 [email protected] Prettify all CMX files (flutter/engine#12800) 2019-10-04 [email protected] Restart all modern Samsung keyboard IMM (flutter/engine#12780) 2019-10-04 [email protected] Reland fuchsia build improvements (flutter/engine#12795) 2019-10-04 [email protected] Fixing selection issues in Firefox (flutter/engine#12793) 2019-10-04 [email protected] Disable EmbedderTest::CanLaunchAndShutdownMultipleTimes. (flutter/engine#12799) 2019-10-04 [email protected] [flutter_runner] Update the cmx files to include TZ support (flutter/engine#12798) 2019-10-04 [email protected] Roll src/third_party/skia fbdf48ecb204..95edac1c9a4a (1 commits) (flutter/engine#12790) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/7d90779bb66f...1d62160 git log 7d90779..1d62160 --no-merges --oneline 2019-10-04 [email protected] Prettify all CMX files (flutter/engine#12800) 2019-10-04 [email protected] Restart all modern Samsung keyboard IMM (flutter/engine#12780) 2019-10-04 [email protected] Reland fuchsia build improvements (flutter/engine#12795) 2019-10-04 [email protected] Fixing selection issues in Firefox (flutter/engine#12793) 2019-10-04 [email protected] Disable EmbedderTest::CanLaunchAndShutdownMultipleTimes. (flutter/engine#12799) 2019-10-04 [email protected] [flutter_runner] Update the cmx files to include TZ support (flutter/engine#12798) 2019-10-04 [email protected] Roll src/third_party/skia fbdf48ecb204..95edac1c9a4a (1 commits) (flutter/engine#12790) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
|
Hi @nturgut |
Contributor
|
@jadolg Would you mind filing a new issue with information about the browser, build mode, and output from |
|
I just created flutter/flutter#50101 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 issues:
On the context menu select all was not working for firefox. All the other events are using onselectionchange (https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onselectionchange) For firefox, onSelect listener is added.
Moving the cursor by mouse selection was not working since the input/textarea element was not a child of glass pane. This PR moves the dom element under glass pane.
Fixing issue flutter/flutter#41633
This is also a good first step for: flutter/flutter#32213 since the gestures on the text field will be sync'ed to Flutter Framework now.
Fixing issue flutter/flutter#41643 Since the touch gestures are sync'ed to Flutter Framework