Make iOS FlutterViewController stop sending inactive/pause on app lifecycle events when not visible #12128

xster · 2019-09-10T09:25:45Z

A non-dealloc'ed FlutterViewController is still observing the application lifecycle events and still forwarding events to Dart while it's not visible though it makes no sense that a showing, dismissing a FlutterViewController and then going to be the background and back will put Dart back into resumed state.

jmagman · 2019-09-11T18:20:59Z

Should we hold off on this until #11890 merges and you can rebase on that?

xster · 2019-09-11T18:29:27Z

Yes, let's do them in order

xster · 2019-09-12T23:40:11Z

I retweaked the tests a bit. I frontloaded the ordering and kept one list instead of 2.

jmagman

I just noticed that -[ScreenBeforeFlutter engine] isn't synthesized correctly.

@implementation ScreenBeforeFlutter // missing {
FlutterEngine* _engine;
// missing }
...
- (FlutterEngine*)engine {
  return _engine;
}

This should be:

@implementation ScreenBeforeFlutter
@synthesize engine = _engine;

jmagman · 2019-09-13T00:06:32Z

testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m

+  // otherwise.
+  self = [self initWithDescription:[NSString stringWithFormat:@"Expected state %@ during step %@",
+                                                              expectedLifecycle, step]];
+  _expectedLifecycle = expectedLifecycle;


[expectedLifecycle copy]

jmagman · 2019-09-13T00:06:36Z

testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m

+@interface XCAppLifecycleTestExpectation : XCTestExpectation
+
+- (instancetype)initForLifecycle:(NSString*)expectedLifecycle forStep:(NSString*)step;
+@property(nonatomic, readonly) NSString* expectedLifecycle;


jmagman · 2019-09-14T01:02:21Z

testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m

+  // The step is here because the callbacks into the handler which checks these expectations isn't
+  // synchronous with the executions in the test, so it's hard to find the cause in the test
+  // otherwise.
+  self = [self initWithDescription:[NSString stringWithFormat:@"Expected state %@ during step %@",


[super initWithDescription:] not self.

jmagman

LGTM with those changes.

xster · 2019-09-14T10:35:36Z

thanks for reviewing

xster · 2019-09-16T21:33:52Z

Break announce: https://groups.google.com/forum/#!topic/flutter-announce/vRxZZKmOHXI.

Merging tomorrow.

… app lifecycle events when not visible (flutter/engine#12128)

[email protected]:flutter/engine.git/compare/63873d9f421f...d1692d4 git log 63873d9..d1692d4 --no-merges --oneline 2019-09-17 [email protected] Update canvaskit backend (flutter/engine#12318) 2019-09-17 [email protected] README for the felt tool (flutter/engine#12323) 2019-09-17 [email protected] Fix continuous event polling in the GLFW event loop (flutter/engine#12320) 2019-09-17 [email protected] Tests for #11283 (flutter/engine#12322) 2019-09-17 [email protected] Improve check to render (or not) a DRRect when inner falls outside of outer on RecordingCanvas (flutter/engine#12229) 2019-09-17 [email protected] Roll src/third_party/dart dd1969a43a..7505b3a5f0 (39 commits) 2019-09-17 [email protected] Channel buffers (flutter/engine#12167) 2019-09-17 [email protected] Make iOS FlutterViewController stop sending inactive/pause on app lifecycle events when not visible (flutter/engine#12128) 2019-09-17 [email protected] Adds PluginRegistry to the C++ client wrapper API (flutter/engine#12287) 2019-09-17 [email protected] Add "type" to getDisplayRefreshRate protocol (flutter/engine#12319) 2019-09-17 [email protected] Add a build command to felt (flutter/engine#12303) 2019-09-17 [email protected] Roll src/third_party/skia df432d5efb70..d545bfbb94ca (1 commits) (flutter/engine#12316) 2019-09-17 [email protected] Roll fuchsia/sdk/core/linux-amd64 from rwf0-... to RRgw-... (flutter/engine#12315) 2019-09-17 [email protected] Roll src/third_party/skia f8486f2c5fb6..df432d5efb70 (1 commits) (flutter/engine#12313) 2019-09-17 [email protected] Roll src/third_party/skia b47704b0bd34..f8486f2c5fb6 (2 commits) (flutter/engine#12312) 2019-09-16 [email protected] Fix the declaration of setSystemGestureExclusionRects to match the PlatformMessageHandler interface (flutter/engine#12306) 2019-09-16 [email protected] Manage resource and onscreen contexts using separate IOSGLContext objects (flutter/engine#12277) 2019-09-16 [email protected] Cleanup in web_ui (flutter/engine#12307) 2019-09-16 [email protected] Made flutter startup faster by allowing initialization to be parallelized (flutter/engine#10182) 2019-09-16 [email protected] Roll src/third_party/skia c22498502cda..b47704b0bd34 (16 commits) (flutter/engine#12304) 2019-09-16 [email protected] Include firefox in check to quote font families (flutter/engine#12288) 2019-09-16 [email protected] Roll src/third_party/dart 7799f424f4..dd1969a43a (2 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

[email protected]:flutter/engine.git/compare/63873d9f421f...d1692d4 git log 63873d9..d1692d4 --no-merges --oneline 2019-09-17 [email protected] Update canvaskit backend (flutter/engine#12318) 2019-09-17 [email protected] README for the felt tool (flutter/engine#12323) 2019-09-17 [email protected] Fix continuous event polling in the GLFW event loop (flutter/engine#12320) 2019-09-17 [email protected] Tests for flutter#11283 (flutter/engine#12322) 2019-09-17 [email protected] Improve check to render (or not) a DRRect when inner falls outside of outer on RecordingCanvas (flutter/engine#12229) 2019-09-17 [email protected] Roll src/third_party/dart dd1969a43a..7505b3a5f0 (39 commits) 2019-09-17 [email protected] Channel buffers (flutter/engine#12167) 2019-09-17 [email protected] Make iOS FlutterViewController stop sending inactive/pause on app lifecycle events when not visible (flutter/engine#12128) 2019-09-17 [email protected] Adds PluginRegistry to the C++ client wrapper API (flutter/engine#12287) 2019-09-17 [email protected] Add "type" to getDisplayRefreshRate protocol (flutter/engine#12319) 2019-09-17 [email protected] Add a build command to felt (flutter/engine#12303) 2019-09-17 [email protected] Roll src/third_party/skia df432d5efb70..d545bfbb94ca (1 commits) (flutter/engine#12316) 2019-09-17 [email protected] Roll fuchsia/sdk/core/linux-amd64 from rwf0-... to RRgw-... (flutter/engine#12315) 2019-09-17 [email protected] Roll src/third_party/skia f8486f2c5fb6..df432d5efb70 (1 commits) (flutter/engine#12313) 2019-09-17 [email protected] Roll src/third_party/skia b47704b0bd34..f8486f2c5fb6 (2 commits) (flutter/engine#12312) 2019-09-16 [email protected] Fix the declaration of setSystemGestureExclusionRects to match the PlatformMessageHandler interface (flutter/engine#12306) 2019-09-16 [email protected] Manage resource and onscreen contexts using separate IOSGLContext objects (flutter/engine#12277) 2019-09-16 [email protected] Cleanup in web_ui (flutter/engine#12307) 2019-09-16 [email protected] Made flutter startup faster by allowing initialization to be parallelized (flutter/engine#10182) 2019-09-16 [email protected] Roll src/third_party/skia c22498502cda..b47704b0bd34 (16 commits) (flutter/engine#12304) 2019-09-16 [email protected] Include firefox in check to quote font families (flutter/engine#12288) 2019-09-16 [email protected] Roll src/third_party/dart 7799f424f4..dd1969a43a (2 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

googlebot added the cla: yes label Sep 10, 2019

xster requested review from dnfield and jmagman September 10, 2019 09:25

xster added the Work in progress (WIP) Not ready (yet) for review! label Sep 11, 2019

xster force-pushed the fix-ios-lifecycle branch 2 times, most recently from 82b9369 to 074391f Compare September 12, 2019 23:38

xster removed the Work in progress (WIP) Not ready (yet) for review! label Sep 12, 2019

xster force-pushed the fix-ios-lifecycle branch from 074391f to 9f1027a Compare September 13, 2019 20:30

jmagman suggested changes Sep 14, 2019

View reviewed changes

jmagman approved these changes Sep 14, 2019

View reviewed changes

xster added 5 commits September 14, 2019 03:18

fix it

c810eef

tests

f169e7f

refactor the tests a bit. Remove the double list

d7ac6e8

remove excessive teardown steps

5b1f0ec

reiew

8fb7fc6

xster force-pushed the fix-ios-lifecycle branch from e9c7e15 to 8fb7fc6 Compare September 14, 2019 10:35

autoformat

0f218c1

xster added the prod: API break label Sep 16, 2019

xster mentioned this pull request Sep 16, 2019

Manage resource and onscreen contexts using separate IOSGLContext objects #12277

Merged

xster merged commit 4159c2b into flutter:master Sep 17, 2019

xster deleted the fix-ios-lifecycle branch September 17, 2019 19:00

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 17, 2019

4159c2b Make iOS FlutterViewController stop sending inactive/pause on…

1efc96b

… app lifecycle events when not visible (flutter/engine#12128)

engine-flutter-autoroll mentioned this pull request Sep 17, 2019

Roll engine 63873d9f421f..d1692d4cc703 (22 commits) flutter/flutter#40717

Merged

Make iOS FlutterViewController stop sending inactive/pause on app lifecycle events when not visible #12128

Make iOS FlutterViewController stop sending inactive/pause on app lifecycle events when not visible #12128

Uh oh!

Conversation

xster commented Sep 10, 2019

Uh oh!

jmagman commented Sep 11, 2019

Uh oh!

xster commented Sep 11, 2019

Uh oh!

xster commented Sep 12, 2019

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

xster Sep 14, 2019

Choose a reason for hiding this comment

Uh oh!

jmagman Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

xster Sep 14, 2019

Choose a reason for hiding this comment

Uh oh!

jmagman Sep 14, 2019

Choose a reason for hiding this comment

Uh oh!

xster Sep 14, 2019

Choose a reason for hiding this comment

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

xster commented Sep 14, 2019

Uh oh!

xster commented Sep 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants