Skip to content

Conversation

@ditman
Copy link
Member

@ditman ditman commented Nov 15, 2024

This change is in preparation of the removal of --web-renderer=html.

Tests

In this case, CI should continue normally. The change is just adopting a new major version of package:web_benchmarks that removed some public API (that wasn't used in devtools).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

If you need help, consider asking for help on Discord.

@elliette elliette self-requested a review November 15, 2024 21:21
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 15, 2024
@auto-submit auto-submit bot merged commit 95e2baa into flutter:master Nov 15, 2024
23 checks passed
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 15, 2024
@ditman ditman deleted the update-web-benchmarks-pkg branch November 15, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants