[Inspector V2] Request the reduced widget tree from Flutter #8480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
requested review from
bkonyi and
kenzieschmoll
and removed request for
a team
Member
kenzieschmoll
left a comment
kenzieschmoll
left a comment
There was a problem hiding this comment.
Is there a way to test this to verify we are getting the smaller tree? Perhaps an inspector text golden test that checks this case?
Member
Author
Good point, added a test case to the integration test (which is using a real app). I've added a check that the JSON object for each node only contains the information we expect for the small tree. |
packages/devtools_app/test/inspector_v2/inspector_integration_test.dart
Outdated
Show resolved
Hide resolved
bkonyi
approved these changes
Oct 29, 2024
packages/devtools_app/test/inspector_v2/inspector_integration_test.dart
Outdated
Show resolved
Hide resolved
mossmana
pushed a commit
to mossmana/devtools
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #1423
Uses the
fullDetails=falseparameter added in flutter/flutter#157309 to request the smaller widget tree.