Skip to content

unwrap transition data encoded by the new schema #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yjbanov merged 1 commit into from
Oct 25, 2016
Merged

unwrap transition data encoded by the new schema #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions app/web/firebase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,19 @@ var whenFirebaseReady = new Promise(function(resolve, reject) {
clone.querySelector('.metric-name').textContent = title;
let chart = clone.querySelector('.frames');

for (let screenName in data) {
if (data.hasOwnProperty(screenName)) {
// TODO(yjbanov): old schema puts transitions data at the root of the data object. As of
// https://github.com/flutter/flutter/pull/6505 it is nested under 'transitions' to make room
// for frame data. This step should be removed when old data is no longer relevant.
var transitionData = data.hasOwnProperty('transitions')
? data['transitions']
: data;

for (let screenName in transitionData) {
if (transitionData.hasOwnProperty(screenName)) {
if (screenName == '__metadata__') {
continue;
}
let durations = data[screenName];
let durations = transitionData[screenName];
durations.forEach(function(duration) {
let div;
if (duration > 300000) {
Expand Down