Skip to content

do not erase screen while loading; graceful handling of missing data #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yjbanov merged 1 commit into from
Oct 21, 2016
Merged

do not erase screen while loading; graceful handling of missing data #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/lib/components/benchmark_grid.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ import 'package:http/http.dart' as http;
@Component(
selector: 'benchmark-grid',
template: r'''
<div *ngIf="isLoading">Loading...</div>
<div *ngIf="!isLoading" class="card-container">
<div *ngIf="isLoading" style="position: fixed; top: 0; left: 0; z-index: 1000; background-color: #AAFFAA;">Loading...</div>
<div *ngIf="benchmarks != null" class="card-container">
<benchmark-card
*ngFor="let benchmark of benchmarks"
[data]="benchmark">
Expand Down Expand Up @@ -78,7 +78,7 @@ class BenchmarkCard implements AfterViewInit {
String get label => _data.timeseries.timeseries.label;
String get unit => _data.timeseries.timeseries.unit;
String get latestValue {
if (_data.values.isEmpty) return null;
if (_data.values == null || _data.values.isEmpty) return null;
num value = _data.values.first.value;
if (value > 100) {
// Ignore fractions in large values.
Expand Down