kill dangling Flutter task processes more aggressively

[yjbanov]

On the iOS bot we leave a lot of dangling Flutter processes that take up all of the CPU time. This change scans for all processes running in the Flutter repo directory and SIGKILLs them.

/cc @chinmaygarde

[eseidelGoogle]

Do we know why the processes end up dangled?

On Wed, Oct 5, 2016 at 4:54 PM, Yegor [email protected] wrote:

On the iOS bot we leave a lot of dangling Flutter processes that take up
all of the CPU time. This change scans for all processes running in the
Flutter repo directory and SIGKILLs them.

/cc @chinmaygarde https://github.com/chinmaygarde

You can view, comment on, or merge this pull request online at:

#63
Commit Summary

• kill dangling Flutter task processes more aggressively

File Changes

• M agent/lib/src/runner.dart
  https://github.com/flutter/cocoon/pull/63/files#diff-0 (51)

Patch Links:

• https://github.com/flutter/cocoon/pull/63.patch
• https://github.com/flutter/cocoon/pull/63.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#63, or mute the thread
https://github.com/notifications/unsubscribe-auth/ALTvi052o_EeP9xzVPudwI73zWxVUuD-ks5qxDilgaJpZM4KPaQ6
.

[yjbanov]

No, but I know which ones: flutter run --profile --trace-startup

[yjbanov]

BTW, this fix is not fixing the issue in Flutter, only protects the test bot from polluting the environment with busy-waiting processes. The offending code lives in the flutter/flutter repo.

[chinmaygarde]

A better fix would be to figure out why those processes aren't terminating gracefully. Can we attach the debugger to one of those errant processes? (maybe after a build with debug symbols). It is possible it is something silly like not passing the --non-interactive flags or something.

[yjbanov]

A better fix would be to figure out why those processes aren't terminating gracefully.

+1. Logged flutter/flutter#6228.

I would still like to put this code in place is because Cocoon is only a piece of testing infrastructure. It should be build to not trust code-under-test. Specifically, here, Cocoon should trust that code-under-test will quit gracefully. Otherwise a failure in one test will leak to another test, resulting in flakes.

[chinmaygarde]

I would still like to put this code in place is because Cocoon is only a piece of testing infrastructure. It should be build to not trust code-under-test.

lgtm