Skip to content

kill no longer used runTaskFile #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yjbanov merged 1 commit into from
Sep 29, 2016
Merged

kill no longer used runTaskFile #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions agent/bin/agent.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ Future<Null> main(List<String> rawArgs) async {
'config-file',
abbr: 'c',
defaultsTo: 'config.yaml'
)
..addOption(
'agent-checkout',
abbr: 'a',
defaultsTo: '.'
);
argParser.addCommand('ci');

Expand Down
10 changes: 0 additions & 10 deletions agent/lib/src/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ class Config {
@required this.firebaseFlutterDashboardToken,
@required this.authToken,
@required this.flutterDirectory,
@required this.runTaskFile,
@required this.deviceOperatingSystem,
});

Expand All @@ -280,12 +279,6 @@ class Config {
throw ('Agent config file not found: ${agentConfigFile.path}.');
}

File runTaskFile = file('${args['agent-checkout']}/bin/agent.dart');

if (!runTaskFile.existsSync()) {
throw ('run_task.dart file not found: ${runTaskFile.path}.');
}

Map<String, dynamic> agentConfig = loadYaml(agentConfigFile.readAsStringSync());
String baseCocoonUrl = agentConfig['base_cocoon_url'] ?? 'https://flutter-dashboard.appspot.com';
String agentId = requireConfigProperty(agentConfig, 'agent_id');
Expand All @@ -312,7 +305,6 @@ class Config {
firebaseFlutterDashboardToken: firebaseFlutterDashboardToken,
authToken: authToken,
flutterDirectory: flutterDirectory,
runTaskFile: runTaskFile,
deviceOperatingSystem: deviceOperatingSystem,
);
}
Expand All @@ -322,7 +314,6 @@ class Config {
final String firebaseFlutterDashboardToken;
final String authToken;
final Directory flutterDirectory;
final File runTaskFile;
final DeviceOperatingSystem deviceOperatingSystem;

String get adbPath {
Expand All @@ -346,7 +337,6 @@ class Config {
baseCocoonUrl: $baseCocoonUrl
agentId: $agentId
flutterDirectory: $flutterDirectory
runTaskFile: $runTaskFile
adbPath: ${deviceOperatingSystem == DeviceOperatingSystem.android ? adbPath : 'N/A'}
deviceOperatingSystem: $deviceOperatingSystem
'''.trim();
Expand Down