Run presubmit tests for cocoon and engine automatically on luci. #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Dec 13, 2019
Contributor
There was a problem hiding this comment.
I think the mergeable should probably be removed - it's not trustworthy based on other experience.
dnfield
reviewed
Dec 13, 2019
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
The change looks good - can we add/update relevant tests?
Both cocoon and engine are ready to start running luci presubmit tests automatically. This add support for cocoon repo and removes the need for CQ+1 on engine commits.
godofredoc
commented
Dec 17, 2019
Contributor
Author
godofredoc
left a comment
godofredoc
left a comment
There was a problem hiding this comment.
Updated and added the relevant tests.
dnfield
reviewed
Dec 17, 2019
| const List<String> supportedRepos = <String>['engine', 'flutter', 'cocoon']; | ||
|
|
||
| /// List of repos that require CQ+1 label. | ||
| const List<String> needsCQLabelList = <String>['flutter/flutter']; |
Contributor
There was a problem hiding this comment.
Both of these should be Sets.
dnfield
approved these changes
Dec 17, 2019
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM with set change - not a big deal right now but will be a big deal if we add more repos here.
Contributor
|
fixes flutter/flutter#45562 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both cocoon and engine are ready to start running luci presubmit tests
automatically. This add support for cocoon repo and removes the need for
CQ+1 on engine commits.
flutter/flutter#43348