Split Android/iOS impl behind a unified interface #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Sep 22, 2016
agent/lib/src/adb.dart
Outdated
Member
There was a problem hiding this comment.
return _instance ??= new AndroidDeviceDiscovery._();
agent/lib/src/adb.dart
Outdated
Member
There was a problem hiding this comment.
I'd be tempted to write as a block:
if (_workingDevice == null)
throw new StateError(...);
return _workingDevice;Probably the same number of lines, but marginally clearer.
agent/lib/src/adb.dart
Outdated
Member
There was a problem hiding this comment.
pedantic nit: prefer isEmpty.
agent/lib/src/adb.dart
Outdated
agent/lib/src/adb.dart
Outdated
agent/lib/src/commands/ci.dart
Outdated
Member
There was a problem hiding this comment.
pedantic nit: prefer isNotEmpty.
- Split Android/iOS impl behind a unified interface; most changes are in `adb.dart` (keeping the name for now), everything else just cascading refactoring. - Bonus: fix deserialization of `required_agent_capabilities` manifest field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
adb.dart(keeping the name for now), everything else justcascading refactoring.
required_agent_capabilitiesmanifestfield