read tasks from manifest; misc. fixes #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- read tasks from manifest instead of hard-coding - create a reusable FetchURL method - switch away from the packages directory - remove the `errr` hack
devoncarew
reviewed
Sep 19, 2016
| makeTask("devicelab", "flutter_gallery__build", []string{"has-android-device"}), | ||
| makeTask("devicelab", "complex_layout__build", []string{"has-android-device"}), | ||
| makeTask("devicelab", "basic_material_app__size", []string{"has-android-device"}), | ||
| url := fmt.Sprintf("https://raw.githubusercontent.com/flutter/flutter/%v/dev/devicelab/manifest.yaml", commit) |
Contributor
There was a problem hiding this comment.
Is the manifest.yaml file already committed?
Contributor
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is phase 1 of moving all our CI tests into the flutter/flutter repo. Phase 2 will be to run from the sources in the flutter/flutter repo.
errrhack