-
Notifications
You must be signed in to change notification settings - Fork 100
Add Hot Dev Cycle benchmarks #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
johnmccutchan
merged 1 commit into
flutter:master
from
johnmccutchan:add_hot_mode_benchmark
Sep 13, 2016
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| // Copyright (c) 2016 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'dart:async'; | ||
| import 'dart:io'; | ||
|
|
||
| import 'package:path/path.dart' as path; | ||
|
|
||
| import 'adb.dart'; | ||
| import 'benchmarks.dart'; | ||
| import 'framework.dart'; | ||
| import 'utils.dart'; | ||
|
|
||
| Task createHotDevCycleTest({ | ||
| String commit, | ||
| DateTime timestamp | ||
| }) => new HotDevCycleTask(commit, timestamp); | ||
|
|
||
| class HotDevCycleTask extends Task { | ||
| HotDevCycleTask(this.commit, this.timestamp) | ||
| : super('hot_mode_dev_cycle__benchmark') { | ||
| assert(commit != null); | ||
| assert(timestamp != null); | ||
| } | ||
|
|
||
| final String commit; | ||
| final DateTime timestamp; | ||
|
|
||
| Directory get appDir => | ||
| dir(path.join(config.flutterDirectory.path, | ||
| 'examples/flutter_gallery')); | ||
|
|
||
| File get benchmarkFile => | ||
| file(path.join(appDir.path, 'hot_benchmark.json')); | ||
|
|
||
| final List<String> benchmarkScoreKeys = [ | ||
| 'hotReloadMillisecondsToFrame', | ||
| 'hotRestartMillisecondsToFrame' | ||
| ]; | ||
|
|
||
| @override | ||
| Future<TaskResultData> run() async { | ||
| Adb device = await adb(); | ||
| device.unlock(); | ||
| rm(benchmarkFile); | ||
| await inDirectory(appDir, () async { | ||
| return await flutter( | ||
| 'run', | ||
| options: ['--hot', '-d', device.deviceId, '--benchmark'], | ||
| canFail: false | ||
| ); | ||
| }); | ||
| return new TaskResultData.fromFile(benchmarkFile, | ||
| benchmarkScoreKeys: benchmarkScoreKeys); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list could be inlined since it's not reused anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.