reduce task retry count 3 -> 2; do not start adb when restarting #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: Failing tasks tend to hand due to flutter/flutter#5477. This is a quick fix to unblock the dashboard when there are many failing tasks. For some reason `adb start-server` sometimes fails to exit. This change removes this command. It should be safe to only kill the server because any `adb` command causes it to start automatically anyway.
Contributor
Author
|
I'll TBR and deploy to unblock the build. |
Member
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
Failing tasks tend to hand due to
flutter/flutter#5477. This is a quick fix to
unblock the dashboard when there are many failing tasks.
For some reason
adb start-serversometimes fails to exit. This changeremoves this command. It should be safe to only kill the server because
any
adbcommand causes it to start automatically anyway./cc @cbracken