Skip to content

Conversation

@TahaTesser
Copy link
Member

Related flutter/flutter#155072

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@TahaTesser TahaTesser requested a review from Piinks September 12, 2024 16:38
@TahaTesser TahaTesser changed the title Remove themeData.dialogBackgroundColor usage Remove ThemeData.dialogBackgroundColor usage Sep 12, 2024
@TahaTesser
Copy link
Member Author

First cocoon PR! 🎉

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First cocoon PR! 🎉
Woohoo! Welcome to cocoon!

There are some differences in CI in this repo, like the autoformatter and analyzer setttings.
Looks like there are some analysis failures right now, can you take a loook?

@TahaTesser

This comment was marked as resolved.

@gaaclarke
Copy link
Member

@TahaTesser I think you got your answer in another thread, but you'll want to use isSameColorAs

@jmagman
Copy link
Member

jmagman commented Sep 13, 2024

Suggest rebasing onto #3902.

@TahaTesser TahaTesser requested a review from Piinks September 23, 2024 07:27
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App. label Sep 24, 2024
@auto-submit auto-submit bot merged commit f21b10f into flutter:main Sep 24, 2024
@TahaTesser TahaTesser deleted the remove_dialogBackgroundColor branch September 24, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants