display attempt counts; show more commits; run new tasks first #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commands/get_status.go
Outdated
Member
There was a problem hiding this comment.
uber-nit: here and below: consider extracting a const for readability. Not particularly passionate about it though ;-)
Member
|
lgtm! |
When a task fails we retry it immediately. This is annoying when you want to get the overall picture quickly as the agent can get stuck retrying a task that keeps timing out. This change will cause the agents to run through all tasks before retrying the failed ones. Bonus: display and color-code attempt counts on the dashboard; show more commits on the page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task fails we retry it immediately. This is annoying when you
want to get the overall picture quickly as the agent can get stuck
retrying a task that keeps timing out. This change will cause the
agents to run through all tasks before retrying the failed ones.
Bonus: display and color-code attempt counts on the dashboard; show
more commits on the page
Fixes https://github.com/flutter/cocoon/issues/33
/cc @cbracken