Skip to content

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Aug 4, 2016

  • Add more health checks:
    • can we talk to all connected devices via adb?
    • do we have at least one healthy Android device?
    • can we connect to Firebase?
    • can we connect to Cocoon backend? (relevant for pre-flight check only; if fails while running CI we won't be able to upload the health check to Cocoon)
  • Upload health status to Cocoon before each task
  • Show agent health status on the dashboard (and track health check age)
  • Color code successful tasks that succeeded after >1 attempts (i.e. flaky)
  • Fix Firebase health check (we never read the value and always succeeded)

Fixes https://github.com/flutter/cocoon/issues/15

/cc @cbracken

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buf.writeln(...)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@cbracken
Copy link
Member

cbracken commented Aug 6, 2016

lgtm other than a couple minor nits!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants