simplify dangling process cleanup #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agent/lib/src/utils.dart
Outdated
Member
There was a problem hiding this comment.
Should this be set in startProcess()?
Contributor
Author
There was a problem hiding this comment.
startProcess() instantiates this class so there won't be any difference. Is there some advantage that I'm missing?
Member
There was a problem hiding this comment.
Nope my bad. Missed that it instantiates this and throws it in the _runningProcesses list. Why isn't startProcess static?
Contributor
Author
There was a problem hiding this comment.
It's better than static, it's a top-level function :)
Member
|
lgtm with just a couple minor nits/questions. |
Instead of passing `onKill`/`onCancel` futures around, store running processes in a global list. When a task times out, force-quit all processes still in the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing
onKill/onCancelfutures around, store runningprocesses in a global list. When a task times out, force-quit all
processes still in the list.
Fixes #22
/cc @cbracken