Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cocoon scheduler dart project #1209

Merged
merged 4 commits into from
May 11, 2021

Conversation

CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented May 11, 2021

  • Create scheduler dart project
  • Move scheduler validation logic out of app_dart/lib/src/service/scheduler.dart to scheduler/lib/scheduler.dart
  • Move scheduler protos from app_dart to scheduler
  • Move ci.yaml validation script from app_dart to scheduler
  • Import scheduler into app_dart

Issues

flutter/flutter#82072

@google-cla google-cla bot added the cla: yes label May 11, 2021
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're moving code from app_dart to a dependency on app_dart, i don't think that will change the calculus on version solving at all

@CaseyHillers
Copy link
Contributor Author

If you're moving code from app_dart to a dependency on app_dart, i don't think that will change the calculus on version solving at all

My understanding from the recipe (an example run at https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20validate_ci_config/373/overview) is this would checkout cocoon, but only run pub get on the scheduler project

\cc @christopherfujino who wrote the recipe can verify

@jonahwilliams
Copy link
Member

I guess that would definitely help the problem, but we'd eventually need to get all of the versions bumped anyway

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants