Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jun 25, 2024

DO NOT LAND YET: Please review flutter/engine#53574 first; will merge this once it is approved.

Change engine to use Android 15.

Buildroot step of https://github.com/flutter/flutter/blob/master/docs/platforms/android/Upgrading-Engine's-Android-API-version.md to complete flutter/flutter#150215.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@camsim99 camsim99 marked this pull request as ready for review July 18, 2024 21:44
Copy link

@yaakovschectman yaakovschectman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidbaker
Copy link
Contributor

@matanlurey is it still ok to land new changes in buildroot?

@matanlurey
Copy link
Contributor

Sorry for missing this - but yes, changes to the buildroot are still OK!

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 23, 2024
@auto-submit auto-submit bot merged commit 91c259d into flutter:master Jul 23, 2024
auto-submit bot pushed a commit to flutter/engine that referenced this pull request Jul 24, 2024
**REVIEW BUT DO NOT MERGE:** Will merge after flutter/buildroot#870 lands.

1: Updates engine to use Android 35. Part of flutter/flutter#150215.
Engine step of https://github.com/flutter/flutter/blob/master/docs/platforms/android/Upgrading-Engine's-Android-API-version.md.

2: Updates test runner AGP version to 8.5, engine Gradle version to 8.9 to accommodate update.

3: Fixes lint and suppresses deprecation warnings caused by the update. None of the deprecations are unknown by the team (they are handled in the code), but the tests emitted warnings.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants