This repository was archived by the owner on Apr 21, 2025. It is now read-only.
[Fuchsia] remove build/fuchsia #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thank you Casey to adding Zachary to the change, I am always struggling to find the right owners of each component. |
Contributor
Author
|
Wait for the merge of flutter/engine#51439 first. |
…#838) This is in preparation for moving //buildtools out of the buildroot and into //flutter/buildtools
Contributor
Author
|
Rebased on #838. |
8 tasks
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Mar 19, 2024
After flutter/buildroot#839, the fuchsia_target_api_level becomes a variable in `build/config/fuchsia/gn_configs.gni`, so the target_api_level file and the related gn-args are obsolete and can be removed. Since this change will also bring flutter/buildroot@e9c4eeb in, add @jason-simmons as one of the reviewers. Bug: http://b/40935282 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After flutter/engine#51072, this folder is obsolete and can be removed.
The change is locally tested.
Bug: http://b/40935282
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.